Page MenuHomePhabricator
Create Task
Maniphest T197445

Can't reload a page by clicking article tab after editing in VE
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. Open any page.
  2. Click the "Article" (or whatever namespace you're in) tab, or the "Read" tab and observe that the page reloads.
  3. Click "Edit".
  4. Either edit and save or just cancel the edit.
  5. Repeat step 2.

Expected: The page should reload (especially useful on talk pages, when you want to see whether you got an answer already).
Actual: Nothing happens.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
DesktopArticleTarget: view click handler should only run for active targetmediawiki/extensions/VisualEditormaster+3 -3
Customize query in gerrit

Event Timeline

Schnark created this task.Jun 15 2018, 8:39 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptJun 15 2018, 8:39 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DLynch claimed this task.Jun 18 2018, 3:48 PM
DLynch edited projects, added VisualEditor (Current work); removed VisualEditor.
gerritbot subscribed.Jun 18 2018, 7:03 PM

Change 440907 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget: clean up tab click handlers on teardown

https://gerrit.wikimedia.org/r/440907

gerritbot added a project: Patch-For-Review.Jun 18 2018, 7:03 PM
DLynch moved this task from Incoming to Code review on the VisualEditor (Current work) board.Jun 18 2018, 7:04 PM
matmarex moved this task from Code review to Product owner review on the VisualEditor (Current work) board.Jun 19 2018, 6:48 PM
gerritbot added a comment.Jun 19 2018, 6:54 PM

Change 440907 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget: view click handler should only run for active target

https://gerrit.wikimedia.org/r/440907

Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)); removed Patch-For-Review.Jun 20 2018, 3:37 PM
• Deskana closed this task as Resolved.Jun 25 2018, 2:36 PM
• Deskana triaged this task as Medium priority.
Ryasmeen added a project: Verified.Jun 27 2018, 10:48 PM
ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)); removed MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)).Jun 30 2018, 1:01 PM
• Vvjjkkii renamed this task from Can't reload a page by clicking article tab after editing in VE to quaaaaaaaa.Jul 1 2018, 1:03 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed DLynch as the assignee of this task.
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii edited subscribers, added: DLynch; removed: gerritbot, Aklapper.
CommunityTechBot renamed this task from quaaaaaaaa to Can't reload a page by clicking article tab after editing in VE.Jul 2 2018, 5:06 AM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to DLynch.
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot edited subscribers, added: gerritbot, Aklapper; removed: DLynch.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits