Maniphest T196758

Thanks button icon doesn't appear well on mobile
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	kaldari
	Jun 8 2018, 5:39 PM

Description

See https://en.m.wikipedia.org/wiki/Special:MobileDiff/476145819 for example (must be logged in). Needs some padding or margin to separate the icon from the "Thank" text.

Screen Shot 2018-06-08 at 10.14.24 AM.png (433×428 px, 78 KB)

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	SpecialMobileDiff: Fix margin and vertical alignment on Thanks button	mediawiki/extensions/MobileFrontend	master	+6 -0

Customize query in gerrit

Related Objects

Mentioned In: T198151: Upgrade Thanks icon

Event Timeline

kaldari created this task.Jun 8 2018, 5:39 PM

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJun 8 2018, 5:39 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

kaldari renamed this task from Thanks button doesn't appear well on mobile to Thanks button icon doesn't appear well on mobile.Jun 8 2018, 5:40 PM

kaldari updated the task description. (Show Details)

Jdlrobson moved this task from Needs triage to Triaged on the Mobile board.Jun 8 2018, 6:29 PM

kaldari updated the task description. (Show Details)Jun 8 2018, 8:41 PM

konstantinos subscribed.Jun 10 2018, 4:20 PM

konstantinos claimed this task.Jun 11 2018, 4:24 PM

kostajh claimed this task.Jun 12 2018, 2:27 PM

Change 440051 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/MobileFrontend@master] SpecialMobileDiff: Fix margin and vertical alignment on Thanks button

https://gerrit.wikimedia.org/r/440051

gerritbot added a project: Patch-For-Review.Jun 13 2018, 3:19 AM

JTannerWMF edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.Jun 13 2018, 2:49 PM

JTannerWMF moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

kostajh moved this task from Ready for Pickup to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jun 13 2018, 4:06 PM

Change 440051 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] SpecialMobileDiff: Fix margin and vertical alignment on Thanks button

https://gerrit.wikimedia.org/r/440051

Jdlrobson moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jun 13 2018, 11:54 PM

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)).Jun 14 2018, 12:00 AM

kaldari merged a task: T192513: Icon misalignment in mobile Thanks button.Jun 16 2018, 4:47 PM

kaldari added subscribers: RazeSoldier, Psuranas.