Maniphest T195459

Fullscreen map cuts under it's footer
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	TheDJ
	May 24 2018, 9:40 AM

Description

The dimensions of the Fullscreen map cut under it's footer, making the attribution partially illegible. This is because .mw-kartographer-mapDialog-map has bottom:4.11em, whereas the other elements have 4.5em. This was recently introduced after this fullscreen panel had some rework done.

Screen Shot 2018-05-24 at 11.39.20.png (770×1 px, 274 KB)

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix display of map footer	mediawiki/extensions/Kartographer	master	+1 -1

Customize query in gerrit

Event Timeline

TheDJ created this task.May 24 2018, 9:40 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 24 2018, 9:40 AM

TheDJ triaged this task as Low priority.May 24 2018, 9:40 AM

TheDJ edited projects, added Maps (Kartographer); removed KartoEditor.

TheDJ added a project: Collaboration-Team-Triage.

TheDJ added a project: good first task.

JTannerWMF edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.May 30 2018, 6:13 PM

JTannerWMF moved this task from Untriaged to Snack Box on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

kostajh claimed this task.Jun 14 2018, 2:28 PM

Change 440363 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/Kartographer@master] Fix display of map footer

https://gerrit.wikimedia.org/r/440363

gerritbot added a project: Patch-For-Review.Jun 14 2018, 4:15 PM

kostajh moved this task from Snack Box to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jun 14 2018, 4:35 PM

Change 440363 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Fix display of map footer

https://gerrit.wikimedia.org/r/440363

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)).Jun 15 2018, 11:09 AM

@TheDJ thanks for reporting this issue! A fix has been committed.

SBisson moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jun 19 2018, 12:34 PM

Checked in testwiki (1.32.0-wmf.999)

Screen Shot 2018-06-21 at 9.16.18 AM.png (117×443 px, 55 KB)

vs. wmf.8

Screen Shot 2018-06-21 at 9.15.54 AM.png (136×453 px, 71 KB)

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)); removed MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)).Jun 26 2018, 6:01 PM

• Vvjjkkii renamed this task from Fullscreen map cuts under it's footer to wdcaaaaaaa.Jul 1 2018, 1:08 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii removed kostajh as the assignee of this task.

• Vvjjkkii raised the priority of this task from Low to High.

• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii edited subscribers, added: kostajh; removed: gerritbot, Aklapper.

CommunityTechBot renamed this task from wdcaaaaaaa to Fullscreen map cuts under it's footer.Jul 2 2018, 1:21 PM

CommunityTechBot closed this task as Resolved.

CommunityTechBot assigned this task to kostajh.

CommunityTechBot lowered the priority of this task from High to Low.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot edited subscribers, added: gerritbot, Aklapper; removed: kostajh.

	F22452152: Screen Shot 2018-06-21 at 9.15.54 AM.png
	Jun 21 2018, 4:18 PM

	F22452121: Screen Shot 2018-06-21 at 9.16.18 AM.png
	Jun 21 2018, 4:18 PM

	F18504980: Screen Shot 2018-05-24 at 11.39.20.png
	May 24 2018, 9:40 AM

Fullscreen map cuts under it's footerClosed, ResolvedPublicActions

Description

Details

Event Timeline

Fullscreen map cuts under it's footer
Closed, ResolvedPublic
Actions