@kaldari & @Mooeypoo I think this would just be a little snippet of JavaScript, but where would it go? I can't imagine that it would go in core. Is there some other place we would put this?

This needs to go on all Wikimedia wikis, so it will need to be translated and deployed.

@alexhollender — Can you please help us decide on the UI element & look and feel for this? Even though this is temporary we still want it to be up to our standards of excellence. Thank you!

@TBolliger maybe something like this?

In T194301#4384276, @alexhollender wrote:

@TBolliger maybe something like this?

I like it! Do you think it needs some sort of "close" icon?

@dbarratt @alexhollender @TBolliger

We talked about this last week and agreed that the wording needs to be changed to lose the "we" to make it more reflective of the participatory design and research approach that we're using.

We talked about this last week and agreed that the wording needs to be changed to lose the "we" to make it more reflective of the participatory design and research approach that we're using.

@SPoore sounds good. Wondering how to phrase this? "There's a discussion happening about improvements to this blocking tool. Come check out the designs and join in"? Open to whatever you think makes sense.

Do you think it needs some sort of "close" icon?

@dbarratt What's your thinking here? I'm not sure it's necessary given that this will only be up for a week, however I'm not opposed to it.

@alexhollender "There's a discussion happening about improvements to this blocking tool. Come check out the designs and join in" is perfect. There needs to be a link to discussion on meta at the end.

In T194301#4391360, @alexhollender wrote:

Do you think it needs some sort of "close" icon?

@dbarratt What's your thinking here? I'm not sure it's necessary given that this will only be up for a week, however I'm not opposed to it.

It's in the acceptance criteria:

A close button, when clicked should make the element disappear & be remembered to not appear again on that device

However, since your design isn't covering anything up, I don't think it's strictly necessary and it's less work for me. :)

Change 443536 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/core@master] Add SpecialBlockTest to test SpecialBlock

https://gerrit.wikimedia.org/r/443536

Change 443648 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/core@master] Add a request for feedback on proposed changes to SpecialBlock.

https://gerrit.wikimedia.org/r/443648

This is what I've got so far. @alexhollender, I eye-balled the spacing and used em's.

In https://gerrit.wikimedia.org/r/c/mediawiki/core/+/443648#message-69ff4643a535310195f346d88e54d2cffbe13d08, @dbarratt wrote:

In https://gerrit.wikimedia.org/r/c/mediawiki/core/+/443648#message-248c5b98cc91d3734dd76785d5ede4d3444bbf2d, @MaxSem wrote:

This is WMF specific so it shouldn't be in the core at all.

I don't think it's WMF specific at all. The changes we are proposing will be made to core.

However, if it shouldn't be in core, where should it be?

In #wikimedia-commtech

davidwbarratt: MaxSem should I make a whole new extension for this?
MaxSem: WikimediaMessages or something ;)
davidwbarratt: MaxSem ah! thank you! I asked on the phab ticket and I didn't get a response so I just put it in core, but I can move it

Unless someone disagrees, I'll move forward with moving this into WikimediaMessages.

I also had an afterthought about doing this as a CentralNotice campaign.

In T194301#4405039, @MaxSem wrote:

I also had an afterthought about doing this as a CentralNotice campaign.

Yeah I looked into it, but it doesn't look like you can target a specific Special page.

mw.config.get( 'wgCanonicalSpecialPageName' ) === 'Block'

In T194301#4405044, @MaxSem wrote:

mw.config.get( 'wgCanonicalSpecialPageName' ) === 'Block'

Ah! I see. I didn't realize you could add JavaScript to it.

In T194301#4405039, @MaxSem wrote:

I also had an afterthought about doing this as a CentralNotice campaign.

I tested this out locally, and I noticed that I couldn't get it to show up on a Special page (even with no JavaScript in the banner), digging into the code I found this:
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/CentralNotice/%2B/a9e91c9edf52ec2a8befcbceacc29131655f05c2/CentralNotice.hooks.php#174

So it looks like WikimediaMessages it is, unless you have another suggestion?

Change 444639 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/extensions/WikimediaMessages@master] Add a request for feedback on proposed changes to SpecialBlock.

https://gerrit.wikimedia.org/r/444639

Change 443648 abandoned by Dbarratt:
Add a request for feedback on proposed changes to SpecialBlock.

Reason:
Moved into WikimediaMessages

https://gerrit.wikimedia.org/r/443648

@MaxSem & @Mooeypoo I noticed that there is no way to get the pre text within an extension, so I created T199115 to fix that, and I used reflection within WikimediaMessages if that patch hasn't been committed yet. There's a test that tests it with and without the new method.

This is what I've got so far. @alexhollender, I eye-balled the spacing and used em's

@dbarratt looking great!

This all looks good. Great job everyone!

Let's try to get this tested, reviewed, deployed, and enabled on wikis as soon as possible — it blocks the rest of our work on the Partial Block project.

@TBolliger I've made the changes requested by @MaxSem & @Mooeypoo. This included swapping the icon for one in OOUI

You can see it here:
https://commtech.wmflabs.org/wiki/Special:Block

But here's a screenshot for everyone else. 😃

woo! 🌟

Looks good! I gave it a test on my machine on Commtech wiki.

Change 444639 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMessages@master] Add a request for feedback on proposed changes to SpecialBlock.

https://gerrit.wikimedia.org/r/444639

@TBolliger & @SPoore This feature will start rolling out today and be global by Thursday, when would you like it to be enabled? (It can be enabled/disabled during any SWAT deploy starting now).

This is already translated on 10+ languages. Let's enable on Thursday, July 19 and disable on Monday July 23.

We can always enable it again later if need be after Wikimania.

Change 449177 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/extensions/WikimediaMessages@master] Escape Special:Block Feedback Request Message

https://gerrit.wikimedia.org/r/449177

Change 449177 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMessages@master] Escape Special:Block Feedback Request Message

https://gerrit.wikimedia.org/r/449177

Change 449258 had a related patch set uploaded (by Thcipriani; owner: Dbarratt):
[mediawiki/extensions/WikimediaMessages@wmf/1.32.0-wmf.14] Escape Special:Block Feedback Request Message

https://gerrit.wikimedia.org/r/449258

Change 449258 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMessages@wmf/1.32.0-wmf.14] Escape Special:Block Feedback Request Message

https://gerrit.wikimedia.org/r/449258

Mentioned in SAL (#wikimedia-operations) [2018-07-30T18:57:55Z] <thcipriani@deploy1001> Synchronized php-1.32.0-wmf.14/extensions/WikimediaMessages/WikimediaMessages.hooks.php: SWAT: [[gerrit:449177|Escape Special:Block Feedback Request Message]] T194301 (duration: 00m 49s)

Change 443536 abandoned by Dbarratt:
Add SpecialBlockTest to test SpecialBlock

https://gerrit.wikimedia.org/r/443536