Page MenuHomePhabricator
Create Task
Maniphest T194252

Configure the CI job that runs WikibaseLexeme's browser tests against beta wikidata
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Two jobs should be created, one running Ruby Selenium tests (selenium-WikibaseLexeme-chrome), one running Node.js Selenium tests (WikibaseLexeme-npm-browser-run-selenium-daily-node-6-docker). Both jobs should run daily and target beta wikidata.

TODO

Ruby selenium-WikibaseLexeme-chrome

💣 T197875: LoadError when running selenium-WikibaseLexeme-chrome Jenkins job

Node.js WikibaseLexeme-npm-browser-run-selenium-daily-node-6-docker

💣 T200011: `ERROR: Cannot find module '../../../../Wikibase/repo/tests/selenium` when running WikibaseLexeme-npm-browser-run-selenium-daily-node-6-docker Jenkins job

Done

✅ selenium-WikibaseLexeme-chrome (Ruby) - Added WikibaseLexeme for a daily Ruby selenium test run, 434016, integration/config
⚰️ Added selenium project for WikibaseLexeme extension, 432983, integration/config
✅ Added beta environment for Ruby browser tests, 432982, mediawiki/extensions/WikibaseLexeme
✅ Parametrize target site in selenium-{name}-jessie, 434024, integration/config
✅ Add missing configuration file for Ruby Selenium tests, 437718, mediawiki/extensions/WikibaseLexeme
✅ Move RubyGems configuration files to root of the repository, 437737, mediawiki/extensions/WikibaseLexeme
✅ Add missing Rake configuration file, 437741, mediawiki/extensions/WikibaseLexeme
✅ 441035 (integration/config): Install dependency extensions when running selenium-WikibaseLexeme-chrome
✅ 441042 (integration/config): Revert "Install dependency extensions when running selenium-WikibaseLexeme-chrome"
✅ 440541 (mediawiki/extensions/WikibaseLexeme): Update installation instructions in readme file
✅ 441393 (mediawiki/extensions/WikibaseLexeme): Selenium: update json Ruby gem
⚰️ Added WikibaseLexeme project for a daily Node.js Selenium test run against beta cluster, 434025, integration/config
⚰️ 441827 (integration/config): Job running WikibaseLexeme Selenium tests daily
✅ Get WikibaseLexeme running locally, following instructions at addshore/mediawiki-docker-dev and WikibaseLexeme
✅ 445652 Selenium: add selenium-daily NPM script

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
zeljkofilipin updated the task description. (Show Details)Jun 15 2018, 1:58 PM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin updated the task description. (Show Details)Jun 15 2018, 2:01 PM
zeljkofilipin updated the task description. (Show Details)Jun 15 2018, 2:03 PM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin updated the task description. (Show Details)Jun 15 2018, 2:05 PM
zeljkofilipin updated the task description. (Show Details)Jun 15 2018, 2:09 PM
zeljkofilipin updated the task description. (Show Details)Jun 15 2018, 2:30 PM
zeljkofilipin updated the task description. (Show Details)
gerritbot added a comment.Jun 15 2018, 3:24 PM

Change 440541 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[mediawiki/extensions/WikibaseLexeme@master] WIP Update installation instructions in readme file

https://gerrit.wikimedia.org/r/440541

zeljkofilipin mentioned this in rEWLE5221dd948112: WIP Update installation instructions in readme file.Jun 15 2018, 3:26 PM
zeljkofilipin updated the task description. (Show Details)Jun 15 2018, 3:26 PM
zeljkofilipin updated the task description. (Show Details)Jun 15 2018, 3:35 PM
zeljkofilipin mentioned this in rEWLE9c8023577452: Update installation instructions in readme file.Jun 15 2018, 3:35 PM
gerritbot added a comment.Jun 18 2018, 8:21 AM

Change 440541 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Update installation instructions in readme file

https://gerrit.wikimedia.org/r/440541

gerritbot added a comment.Jun 19 2018, 12:56 PM

Change 441035 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[integration/config@master] Install dependency extensions when running selenium-WikibaseLexeme-chrome

https://gerrit.wikimedia.org/r/441035

gerritbot added a comment.Jun 19 2018, 1:41 PM

Change 441035 merged by jenkins-bot:
[integration/config@master] Install dependency extensions when running selenium-WikibaseLexeme-chrome

https://gerrit.wikimedia.org/r/441035

gerritbot added a comment.Jun 19 2018, 1:47 PM

Change 441042 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Revert "Install dependency extensions when running selenium-WikibaseLexeme-chrome"

https://gerrit.wikimedia.org/r/441042

gerritbot added a comment.Jun 19 2018, 1:49 PM

Change 441042 merged by jenkins-bot:
[integration/config@master] Revert "Install dependency extensions when running selenium-WikibaseLexeme-chrome"

https://gerrit.wikimedia.org/r/441042

hashar added a comment.Jun 19 2018, 1:54 PM

https://gerrit.wikimedia.org/r/c/integration/config/+/441035 had Zuul to inject the dependencies by the job is triggered by Jenkins itself. Hence the patch would do nothing.

The job would need to define a parameter EXT_DEPENDENCIES with a default set to the list of extensions (separated by \n). Currently the WikibaseLexeme jobs triggered by Zuul receive:

mediawiki/extensions/BetaFeatures\nmediawiki/extensions/Capiunto\nmediawiki/extensions/CentralAuth\nmediawiki/extensions/CirrusSearch\nmediawiki/extensions/Cite\nmediawiki/extensions/Echo\nmediawiki/extensions/EducationProgram\nmediawiki/extensions/Elastica\nmediawiki/extensions/EventLogging\nmediawiki/extensions/GeoData\nmediawiki/extensions/MwEmbedSupport\nmediawiki/extensions/PdfHandler\nmediawiki/extensions/PropertySuggester\nmediawiki/extensions/Scribunto\nmediawiki/extensions/SiteMatrix\nmediawiki/extensions/SyntaxHighlight_GeSHi\nmediawiki/extensions/TimedMediaHandler\nmediawiki/extensions/VisualEditor\nmediawiki/extensions/WikiEditor\nmediawiki/extensions/Wikibase\nmediawiki/extensions/WikibaseQuality\nmediawiki/extensions/WikibaseQualityConstraints\nmediawiki/extensions/WikimediaBadges\nmediawiki/extensions/cldr

You probably only need a subset of all of them. Wikibase might be sufficient.

Note that the job would be to be adjusted to support cloning the repositories listed in EXT_DEPENDENCIES. We have a couple legacy macros to do that AND install mediawiki:

jjb/mediawiki-extensions.yaml
- builder:
    name: prepare-mediawiki-zuul-project
    builders:
     - shell: "echo $ZUUL_PROJECT > deps.txt"
     - shell: "echo -e $EXT_DEPENDENCIES >> deps.txt"
     - shell: "echo -e $SKIN_DEPENDENCIES > deps_skins.txt"
     # Clone both extensions and skins, but only extensions get listed for the
     # extensions autoloader in integration/jenkins.git, skins are
     # automatically injected by MediaWiki upon installation.
     - zuul-cloner:
         projects: >
             mediawiki/core
             mediawiki/vendor
             $(cat deps.txt)
             $(cat deps_skins.txt)
     - ext-skins-submodules-update
     - shell: "mv deps.txt src/extensions_load.txt"
     - mw-install-mysql
     - mw-apply-settings
     - mw-run-update-script

I think you will be fine by copying the first few lines until, and including, the zuul-cloner one:

`
     - shell: "echo -e $EXT_DEPENDENCIES >> deps.txt"
     - zuul-cloner:
         projects: >
             mediawiki/core
             mediawiki/vendor
             $(cat deps.txt)
             $(cat deps_skins.txt)
     - ext-skins-submodules-update
`

ext-skins-submodules-update is to process submodules in all extensions which is probably not needed.

zeljkofilipin updated the task description. (Show Details)Jun 20 2018, 2:15 PM
zeljkofilipin updated the task description. (Show Details)Jun 20 2018, 2:22 PM
zeljkofilipin updated the task description. (Show Details)Jun 20 2018, 2:38 PM
zeljkofilipin updated the task description. (Show Details)
WMDE-leszek added a comment.Jun 20 2018, 2:57 PM

Thanks @hashar for the insight. I am trying to do something along the lines of what you've described. Expect patches soon :)

ext-skins-submodules-update is to process submodules in all extensions which is probably not needed.

Wikibase has some UI things as submodules, so that would be needed here I think.

zeljkofilipin updated the task description. (Show Details)Jun 20 2018, 3:15 PM
zeljkofilipin added a subtask: T197868: `Class 'Wikibase\DataModel\Entity\ItemId' not found` error when trying to install WikibaseLexeme.Jun 21 2018, 2:05 PM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin updated the task description. (Show Details)Jun 21 2018, 2:10 PM
gerritbot added a comment.Jun 21 2018, 2:40 PM

Change 441393 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[mediawiki/extensions/WikibaseLexeme@master] Selenium: update json Ruby gem

https://gerrit.wikimedia.org/r/441393

zeljkofilipin mentioned this in rEWLE1f976f6299e2: Selenium: update json Ruby gem.Jun 21 2018, 2:41 PM
zeljkofilipin updated the task description. (Show Details)Jun 21 2018, 2:42 PM
zeljkofilipin added a subtask: T197875: LoadError when running selenium-WikibaseLexeme-chrome Jenkins job.Jun 21 2018, 3:19 PM
zeljkofilipin updated the task description. (Show Details)Jun 21 2018, 3:21 PM
gerritbot added a comment.Jun 21 2018, 3:33 PM

Change 441393 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Selenium: update json Ruby gem

https://gerrit.wikimedia.org/r/441393

zeljkofilipin updated the task description. (Show Details)Jun 21 2018, 3:40 PM
zeljkofilipin added a subtask: T197882: jenkins_jobs.errors.JenkinsJobsException: Duplicate entry found in '/src/integration/config/jjb/selenium.yaml: 'WikibaseLexeme' already defined.Jun 21 2018, 3:47 PM
zeljkofilipin updated the task description. (Show Details)Jun 21 2018, 3:51 PM
zeljkofilipin updated the task description. (Show Details)Jun 21 2018, 4:04 PM
gerritbot added a comment.Jun 25 2018, 11:19 AM

Change 441827 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[integration/config@master] Job running WikibaseLexeme Selenium tests daily

https://gerrit.wikimedia.org/r/441827

zeljkofilipin updated the task description. (Show Details)Jun 25 2018, 11:20 AM
gerritbot added a comment.Jun 25 2018, 11:27 AM

Change 434025 abandoned by Zfilipin:
WIP Added WikibaseLexeme project for a daily node selenium test run against beta cluster

Reason:
Simpler and working implementation at https://gerrit.wikimedia.org/r/c/integration/config/ /441827

https://gerrit.wikimedia.org/r/434025

zeljkofilipin closed subtask T197882: jenkins_jobs.errors.JenkinsJobsException: Duplicate entry found in '/src/integration/config/jjb/selenium.yaml: 'WikibaseLexeme' already defined as Resolved.Jun 25 2018, 11:29 AM
zeljkofilipin updated the task description. (Show Details)
Diffusion mentioned this in rEWLE043fc59bf3ab: Create change.Jun 28 2018, 11:51 AM
Diffusion mentioned this in rEWLE93a3e44d9f2e: Create change.
Diffusion mentioned this in rEWLE8070721e4173: Update patch set 1.
zeljkofilipin added a project: MediaWiki-Core-Tests.Jun 28 2018, 3:36 PM
zeljkofilipin moved this task from Inbox to Selenium on the MediaWiki-Core-Tests board.
zeljkofilipin moved this task from Deep work 🌊 to Quarter 👔 on the User-zeljkofilipin board.Jun 28 2018, 5:11 PM
ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)); removed MW-1.32-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)).Jun 30 2018, 1:01 PM
• Vvjjkkii reopened subtask T197882: jenkins_jobs.errors.JenkinsJobsException: Duplicate entry found in '/src/integration/config/jjb/selenium.yaml: 'WikibaseLexeme' already defined as Open.Jul 1 2018, 1:02 AM
• Vvjjkkii renamed this task from Configure the CI job that runs WikibaseLexeme's browser tests against beta wikidata to fbdaaaaaaa.Jul 1 2018, 1:11 AM
• Vvjjkkii removed WMDE-leszek as the assignee of this task.
• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed the point value 3 for this task.
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot closed subtask T197882: jenkins_jobs.errors.JenkinsJobsException: Duplicate entry found in '/src/integration/config/jjb/selenium.yaml: 'WikibaseLexeme' already defined as Resolved.Jul 2 2018, 11:22 AM
CommunityTechBot renamed this task from fbdaaaaaaa to Configure the CI job that runs WikibaseLexeme's browser tests against beta wikidata.Jul 2 2018, 1:50 PM
CommunityTechBot assigned this task to WMDE-leszek.
CommunityTechBot set the point value for this task to 3.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
zeljkofilipin closed subtask T197868: `Class 'Wikibase\DataModel\Entity\ItemId' not found` error when trying to install WikibaseLexeme as Resolved.Jul 3 2018, 10:41 AM
zeljkofilipin mentioned this in T188742: Run tests daily targeting beta cluster for all repositories with Selenium tests.Jul 13 2018, 3:25 PM
gerritbot added a comment.Jul 16 2018, 10:18 AM

Change 441827 abandoned by Zfilipin:
Job running WikibaseLexeme Selenium tests daily

Reason:
Replaced with https://gerrit.wikimedia.org/r/c/integration/config/ /443931 and https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/ /445652

https://gerrit.wikimedia.org/r/441827

zeljkofilipin moved this task from Quarter 👔 to Deep work 🌊 on the User-zeljkofilipin board.Jul 16 2018, 10:20 AM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin updated the task description. (Show Details)Jul 17 2018, 10:37 AM
zeljkofilipin updated the task description. (Show Details)Jul 17 2018, 3:37 PM
gerritbot added a comment.Jul 17 2018, 3:38 PM

Change 445652 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[mediawiki/extensions/WikibaseLexeme@master] Selenium: add selenium-daily NPM script

https://gerrit.wikimedia.org/r/445652

zeljkofilipin moved this task from Deep work 🌊 to Waiting 🏹 on the User-zeljkofilipin board.Jul 17 2018, 3:40 PM
zeljkofilipin mentioned this in rEWLE074a9220e327: Selenium: add selenium-daily NPM script.Jul 17 2018, 3:41 PM
zeljkofilipin added a parent task: T188742: Run tests daily targeting beta cluster for all repositories with Selenium tests.Jul 17 2018, 3:41 PM
WMDE-leszek mentioned this in rEWLEbf397b7e98d5: Selenium: add selenium-daily NPM script.Jul 19 2018, 9:17 AM
WMDE-leszek mentioned this in rEWLE706611d680a6: Selenium: add selenium-daily NPM script.
gerritbot added a comment.Jul 19 2018, 1:52 PM

Change 445652 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Selenium: add selenium-daily NPM script

https://gerrit.wikimedia.org/r/445652

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jul 19 2018, 2:00 PM
zeljkofilipin updated the task description. (Show Details)Jul 19 2018, 2:00 PM
zeljkofilipin added a subtask: T200011: `ERROR: Cannot find module '../../../../Wikibase/repo/tests/selenium` when running WikibaseLexeme-npm-browser-run-selenium-daily-node-6-docker Jenkins job.Jul 19 2018, 2:09 PM
zeljkofilipin updated the task description. (Show Details)
Addshore subscribed.Aug 27 2018, 1:50 PM
Addshore closed subtask T200011: `ERROR: Cannot find module '../../../../Wikibase/repo/tests/selenium` when running WikibaseLexeme-npm-browser-run-selenium-daily-node-6-docker Jenkins job as Resolved.Jan 7 2019, 1:18 PM
WMDE-leszek added a comment.Jan 7 2019, 3:44 PM

T200011 got resolved and revealed that, at least when targetting "real" sites not a local wikis, Wikibase(Lexeme) browser tests should include the login step.
See subtask for details of this blocker.

zeljkofilipin removed a project: User-zeljkofilipin.Mar 7 2019, 11:17 AM
Michael mentioned this in T222449: Make existing daily selenium nodejs tests for WikibaseLexeme green again.May 3 2019, 12:55 PM
hashar closed subtask T197875: LoadError when running selenium-WikibaseLexeme-chrome Jenkins job as Resolved.Jun 19 2019, 9:21 AM
Aklapper removed a project: Patch-For-Review.Oct 14 2020, 7:51 PM

@WMDE-leszek: Hi, all related patches in Gerrit have been merged or abandoned. Is there more to do in this task? Asking as you are set as task assignee. Thanks in advance! (You can change the task status via Add Action... → Change Status in the dropdown menu.)

WMDE-leszek closed this task as Resolved.Oct 28 2020, 5:48 AM

Ruby tests have been removed/migrated meanwhile. Node tests got run https://phabricator.wikimedia.org/T222449. There are some issues, but this task is done.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits