Page MenuHomePhabricator
Create Task
Maniphest T193871

Add maintenance script to populate change_tag_def
Closed, ResolvedPublic
Actions

Description

The third part of normalizing change tag schema T185355: Normalize change tag schema

  • This will run the Special:Tags query (in ChangeTags::tagUsageStatistics()) and use it to populate the change_tag_def table. It will also populate ct_tag_id for every row in the change_tag table.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add some output for progress in populateChangeTagDef.phpmediawiki/coremaster+8 -2
Move lbFactory defintion from construct to execute in populateChangeTagDefmediawiki/coremaster+2 -2
Add maintenance to populate change_tag_def table and ct_tag_id fieldmediawiki/coremaster+479 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ladsgroup created this task.May 4 2018, 1:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 4 2018, 1:32 PM
Reedy renamed this task from Add maintaince script to populate change_tag_def to Add maintenance script to populate change_tag_def.May 4 2018, 1:55 PM
Reedy removed a subtask: T193873: Run maintenance script to populate change_tag_def on WMF production (all wikis).
Reedy added a parent task: T193873: Run maintenance script to populate change_tag_def on WMF production (all wikis).
Lucas_Werkmeister_WMDE mentioned this in T185355: Normalize change tag schema.May 8 2018, 2:27 PM
TTO added a comment.May 31 2018, 1:32 AM

I'd like to see this maintenance script written in such a way that it updates the count of tags already present in the table, removing those with ctd_user_defined = 0 and ctd_count = 0. In this way, we can set up a cronjob to update counts on every wiki, say every week or 2 weeks.

As we know from site statistics and category counts, any increment/decrement type counting is bound to get out of sync with reality. This cronjob is, to me, an essential part of this change to how tags are counted.

Ladsgroup added subscribers: • tstarling, hoo.May 31 2018, 10:22 AM

This is a very good point and I think something that we can consider if we want to move towards using different transactions to update the tables. cc. @Anomie @tstarling @hoo

Lucas_Werkmeister_WMDE added a project: Wikidata-Campsite.Jun 5 2018, 1:37 PM
gerritbot subscribed.Jun 5 2018, 10:59 PM

Change 437642 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/core@master] Add maintenance to populate change_tag_def table and ct_tag_id field

https://gerrit.wikimedia.org/r/437642

gerritbot added a project: Patch-For-Review.Jun 5 2018, 10:59 PM
Ladsgroup claimed this task.Jun 5 2018, 11:06 PM
Ladsgroup moved this task from Incoming to Peer Review on the Wikidata-Campsite board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJun 5 2018, 11:06 PM
WMDE-leszek moved this task from Peer Review to In Progress on the Wikidata-Campsite board.Jun 12 2018, 10:03 AM
Ladsgroup moved this task from In Progress to Peer Review on the Wikidata-Campsite board.Jun 14 2018, 8:14 PM
hoo moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite board.Jun 16 2018, 12:45 PM
gerritbot added a comment.Jun 16 2018, 12:59 PM

Change 437642 merged by jenkins-bot:
[mediawiki/core@master] Add maintenance to populate change_tag_def table and ct_tag_id field

https://gerrit.wikimedia.org/r/437642

Ladsgroup moved this task from Test (Verification) to Peer Review on the Wikidata-Campsite board.Jun 18 2018, 4:36 PM
gerritbot added a comment.Jun 18 2018, 4:37 PM

Change 440890 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/core@master] Move lbFactory defintion from construct to execute in populateChangeTagDef

https://gerrit.wikimedia.org/r/440890

gerritbot added a comment.Jun 18 2018, 5:22 PM

Change 440890 merged by jenkins-bot:
[mediawiki/core@master] Move lbFactory defintion from construct to execute in populateChangeTagDef

https://gerrit.wikimedia.org/r/440890

Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite board.Jun 19 2018, 4:22 AM
gerritbot added a comment.Jun 19 2018, 7:04 AM

Change 440990 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/core@master] Add some output for progress in populateChangeTagDef.php

https://gerrit.wikimedia.org/r/440990

Lydia_Pintscher closed this task as Resolved.Jun 20 2018, 3:09 PM
Lydia_Pintscher moved this task from Test (Verification) to Done on the Wikidata-Campsite board.
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)).Jun 21 2018, 6:01 PM
gerritbot added a comment.Jun 26 2018, 10:54 AM

Change 440990 merged by jenkins-bot:
[mediawiki/core@master] Add some output for progress in populateChangeTagDef.php

https://gerrit.wikimedia.org/r/440990

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)); removed MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)).Jun 26 2018, 6:01 PM
• Vvjjkkii renamed this task from Add maintenance script to populate change_tag_def to 0ldaaaaaaa.Jul 1 2018, 1:12 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed Ladsgroup as the assignee of this task.
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from 0ldaaaaaaa to Add maintenance script to populate change_tag_def.Jul 2 2018, 4:28 PM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to Ladsgroup.
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:39 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptOct 16 2020, 5:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits