Reported in checkuser-l I think it's related to deploy of wmf.18 and thus should be a blocker of the train
Specifically, the bug is that IP range checks do not give results even if IPs in that range have edits. For example, a check on 37.228.251.79 correctly shows edits, so a check on 37.228.251.0/24 should show at a minimum those edits from 37.228.251.79, but it (incorrectly) does not show any results at all.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Release | • demon | T170636 1.30.0-wmf.18 deployment blockers | ||
| Resolved | Huji | T175898 Checkuser on IP ranges produces no results, even if there are edits in that range |
Change 378022 had a related patch set uploaded (by Melos; owner: Melos):
[mediawiki/extensions/CheckUser@master] Fix Special cu for ip ranges (temp)
Change 378022 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Fix Special cu for ip ranges (temp)
Change 378025 had a related patch set uploaded (by Melos; owner: Melos):
[mediawiki/extensions/CheckUser@wmf/1.30.0-wmf.18] Fix Special cu for ip ranges (temp)
@Melos where did that line drop from the code base? For regressions like this, it is always best to find out how they occurred, and mention the patch ID in the commit message.
Change 378025 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@wmf/1.30.0-wmf.18] Fix Special cu for ip ranges (temp)
You have to admit the irony, though... before only CUs could see contribs in an IP range, this week ALL users get to (T163562), but it broke for CUs!!! OK not that funny. Sorry :(
I was thinking this function (and others) seem easily unit testable. There aren't any tests right now, though? I'm going to write some :)
Mentioned in SAL (#wikimedia-operations) [2017-09-14T14:07:14Z] <dereckson@tin> Synchronized php-1.30.0-wmf.18/extensions/CheckUser/specials/SpecialCheckUser.php: Fix Special cu for ip ranges (temp) (T175898) (duration: 00m 49s)
Hilarious!
I was thinking this function (and others) seem easily unit testable. There aren't any tests right now, though? I'm going to write some :)
Please join T175920!