Page MenuHomePhabricator
Create Task
Maniphest T175734

History tools not updating state in standalone demo
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

  1. Open standalone
  2. Type
  3. Observe undo is still disabled

This works by chance in MediaWiki because use a dummy surface while initialising and so the surfaceChange event gets triggered when the second 'real' surface gets setup.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update VE core submodule to master (7028f79aa)mediawiki/extensions/VisualEditormaster+2 -1
Follow-up Ifcc2e6f: Emit surfaceChange after tool setupVisualEditor/VisualEditormaster+8 -2
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Sep 12 2017, 7:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 12 2017, 7:18 PM
gerritbot subscribed.Sep 12 2017, 7:18 PM

Change 377535 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Follow-up Ifcc2e6f: Emit surfaceChange after tool setup

https://gerrit.wikimedia.org/r/377535

gerritbot added a project: Patch-For-Review.Sep 12 2017, 7:18 PM
Jdforrester-WMF renamed this task from History tools no updating state in standalone demo to History tools not updating state in standalone demo.Sep 12 2017, 7:22 PM
Jdforrester-WMF added a project: VisualEditor-EditingTools.
• Deskana assigned this task to Esanders.Sep 12 2017, 7:23 PM
• Deskana triaged this task as Medium priority.
• Deskana moved this task from To Triage to TR1: Releases on the VisualEditor board.
• Deskana set the point value for this task to 1.
gerritbot added a comment.Sep 12 2017, 8:43 PM

Change 377535 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Follow-up Ifcc2e6f: Emit surfaceChange after tool setup

https://gerrit.wikimedia.org/r/377535

gerritbot added a comment.Sep 13 2017, 3:30 PM

Change 377766 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7028f79aa)

https://gerrit.wikimedia.org/r/377766

gerritbot added a comment.Sep 13 2017, 3:50 PM

Change 377766 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7028f79aa)

https://gerrit.wikimedia.org/r/377766

• Deskana closed this task as Resolved.Sep 13 2017, 3:51 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 13 2017, 3:51 PM
Jdforrester-WMF edited projects, added MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)); removed Patch-For-Review.Sep 28 2017, 3:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits