NWE shouldn't intercept when viewing deleted revisions
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Repro: have the beta feature enabled, go to the list of deleted revisions for a page, click on a revision, click "Show preview".

I see: NWE tries to open Special:Undelete for editing and you get an empty editor instead of preview.

Expected: same preview dialog as without NWE.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Revert "Disable VE on Special:Undelete"	mediawiki/extensions/VisualEditor	master	+1 -4
	Disable VE on Special:Undelete	mediawiki/extensions/VisualEditor	master	+4 -1

Customize query in gerrit

Related Objects

Mentioned In: T174748: VE/etc. tab missing from Special:Undelete
Mentioned Here: T173090: When deleting revisions, 2017 wikitext editor loads when it shouldn't and blocks you from proceeding

Event Timeline

MaxSem created this task.Aug 11 2017, 11:46 PM

Restricted Application added a project: VisualEditor. · View Herald TranscriptAug 11 2017, 11:46 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Dvorapa subscribed.Aug 12 2017, 9:53 AM

And if the article exists, you will then see preview of the last version of the article, not the old version that you wanted to see.

• Deskana renamed this task from NWE intercepts previews of deleted pages to NWE shouldn't intercept when viewing deleted revisions.Aug 22 2017, 7:24 PM

• Deskana triaged this task as Medium priority.

• Deskana moved this task from To Triage to TR1: Releases on the VisualEditor board.

Change 373927 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Disable VE on Special:Undelete

https://gerrit.wikimedia.org/r/373927

Restricted Application added a subscriber: jeblad. · View Herald TranscriptAug 25 2017, 5:11 PM

gerritbot added a project: Patch-For-Review.Aug 25 2017, 5:11 PM

jeblad unsubscribed.Aug 25 2017, 9:26 PM

Jdforrester-WMF mentioned this in T174748: VE/etc. tab missing from Special:Undelete.Aug 31 2017, 11:32 PM

Change 373927 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Disable VE on Special:Undelete

https://gerrit.wikimedia.org/r/373927

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)).Sep 1 2017, 12:00 AM

• Deskana closed this task as Resolved.Sep 5 2017, 12:12 PM

• Deskana assigned this task to Esanders.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 5 2017, 12:12 PM

Change 471771 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Revert "Disable VE on Special:Undelete"

https://gerrit.wikimedia.org/r/471771

(I fixed the underlying problem in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/471294, so that's no longer needed.)

Jdforrester-WMF edited projects, added VisualEditor (Current work), MW-1.33-notes (1.33.0-wmf.3; 2018-11-06); removed Patch-For-Review, VisualEditor.Nov 5 2018, 6:29 PM

Jdforrester-WMF moved this task from Incoming to QA on the VisualEditor (Current work) board.

Change 471771 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Revert "Disable VE on Special:Undelete"