Page MenuHomePhabricator
Create Task
Maniphest T170275

Replace deprecated OO.ui.TextInputWidget({multiline: true}) with OO.ui.MultilineTextInputWidget
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

  • Core
  • UploadWizard
  • CollaborationKit
  • FileAnnotation
  • Flow
  • MultimediaViewer
  • Math
  • SyntaxHighlight_GeSHi
  • Graph
  • Kartographer
  • Teahouse
  • TemplateData

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Volker_E created this task.Jul 11 2017, 2:15 PM
gerritbot subscribed.Jul 11 2017, 2:18 PM

Change 364425 had a related patch set uploaded (by VolkerE; owner: Matthias Mullie):
[mediawiki/core@master] Use OO.ui.MultilineTextInputWidget

https://gerrit.wikimedia.org/r/364425

gerritbot added a project: Patch-For-Review.Jul 11 2017, 2:18 PM

Change 364413 had a related patch set uploaded (by VolkerE; owner: Matthias Mullie):
[mediawiki/extensions/UploadWizard@master] Use OO.ui.MultilineTextInputWidget

https://gerrit.wikimedia.org/r/364413

Volker_E moved this task from Backlog to Doing on the OOUI board.Jul 11 2017, 3:45 PM
gerritbot added a comment.Jul 11 2017, 3:56 PM

Change 364425 merged by jenkins-bot:
[mediawiki/core@master] Use OO.ui.MultilineTextInputWidget

https://gerrit.wikimedia.org/r/364425

gerritbot added a comment.Jul 11 2017, 3:56 PM

Change 364413 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Use OO.ui.MultilineTextInputWidget

https://gerrit.wikimedia.org/r/364413

ReleaseTaggerBot added a project: MW-1.30-release-notes.Jul 11 2017, 4:00 PM
Jdforrester-WMF edited projects, added MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)); removed MW-1.30-release-notes, Patch-For-Review.Jul 11 2017, 4:58 PM

Any others we're missing?

matmarex added a comment.Jul 11 2017, 6:28 PM

I'm sure there's plenty. Results of a quick search:

(note that these might be missing cases where the option is constructed dynamically, but searching for just 'multiline' gives a lot of false positives)

extensions/CollaborationKit/modules/ext.CollaborationKit.list.ui.js:
  169  		} );
  170  		this.description = new OO.ui.TextInputWidget( {
  171: 			multiline: true,
  172  			label: mw.msg( 'collaborationkit-list-newitem-description' )
  173  		} );

extensions/FileAnnotations/resources/src/FileAnnotationEditor.js:
  100  
  101  		this.textWidget = new OO.ui.TextInputWidget( {
  102: 			multiline: true
  103  		} );
  104  

extensions/Flow/modules/editor/editors/ext.flow.editors.none.js:
   22  		this.widget = new OO.ui.TextInputWidget( {
   23  			value: content || '',
   24: 			multiline: true,
   25  			autosize: true,
   26  			maxRows: 999,

extensions/Flow/modules/flow/ui/widgets/editor/mw.flow.ui.EditorSwitcherWidget.js:
   52  
   53  		this.placeholderInput = new OO.ui.TextInputWidget( {
   54: 			multiline: true,
   55  			placeholder: this.placeholder,
   56  			classes: [ 'flow-ui-editorSwitcherWidget-placeholder-input' ]

extensions/Flow/modules/flow/ui/widgets/editor/editors/mw.flow.ui.WikitextEditorWidget.js:
   20  		// Main textarea
   21  		this.input = new OO.ui.TextInputWidget( {
   22: 			multiline: true,
   23  			autosize: true,
   24  			maxRows: 999,

extensions/Graph/modules/ve-graph/ve.ui.MWGraphDialog.js:
  196  		classes: [ 've-ui-mwGraphDialog-json' ],
  197  		maxRows: 22,
  198: 		multiline: true,
  199  		validate: this.validateRawData
  200  	} );

extensions/Kartographer/modules/ve-maps/ve.ui.MWMapsDialog.js:
   64  
   65  	this.input = new ve.ui.MWAceEditorWidget( {
   66: 		multiline: true,
   67  		autosize: true,
   68  		maxRows: 10,

extensions/Math/modules/ve-math/ve.ui.MWLatexDialog.js:
   97  
   98  	this.input = new ve.ui.MWAceEditorWidget( {
   99: 		multiline: true,
  100  		rows: 1, // This will be recalculated later in onWindowManagerResize
  101  		autocomplete: 'live',

extensions/MultimediaViewer/resources/mmv/ui/mmv.ui.reuse.embed.js:
  120  		this.embedTextHtml = new oo.ui.TextInputWidget( {
  121  			classes: htmlClasses,
  122: 			multiline: true,
  123  			readOnly: true
  124  		} );
  ...
  133  		this.embedTextWikitext = new oo.ui.TextInputWidget( {
  134  			classes: wikitextClasses,
  135: 			multiline: true,
  136  			readOnly: true
  137  		} );

extensions/SyntaxHighlight_GeSHi/modules/ve-syntaxhighlight/ve.ui.MWSyntaxHighlightDialog.js:
   49  	this.input = new ve.ui.MWAceEditorWidget( {
   50  		limit: 1,
   51: 		multiline: true,
   52  		rows: 10,
   53  		maxRows: 25,

extensions/Teahouse/resources/ui/dialog/Question.js:
   60  	this.tiDesc = new OO.ui.TextInputWidget( {
   61  		classes: [ 'teahouse-inputWidget', 'teahouse-tiDesc' ],
   62: 		multiline: true
   63  	});
   64  	this.tiDesc.on( 'change', this.onTiDescChange, [], this );

extensions/TemplateData/modules/ext.templateDataGenerator.data.js:
  158  		'default': {
  159  			type: 'string',
  160: 			multiline: true,
  161  			allowLanguages: true
  162  		},

extensions/TemplateData/modules/ext.templateDataGenerator.ui.tdDialog.js:
  135  
  136  	this.descriptionInput = new OO.ui.TextInputWidget( {
  137: 		multiline: true,
  138  		autosize: true
  139  	} );
gerritbot added a comment.Jul 12 2017, 7:51 AM

Change 364666 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/FileAnnotations@master] Replace TextInputWidget (multiline) with MultilineTextInputWidget

https://gerrit.wikimedia.org/r/364666

gerritbot added a project: Patch-For-Review.Jul 12 2017, 7:51 AM
gerritbot added a comment.Jul 12 2017, 8:07 AM

Change 364670 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/Flow@master] Replace TextInputWidget (multiline) with MultilineTextInputWidget

https://gerrit.wikimedia.org/r/364670

gerritbot added a comment.Jul 12 2017, 8:28 AM

Change 364672 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/MultimediaViewer@master] Replace TextInputWidget (multiline) with MultilineTextInputWidget

https://gerrit.wikimedia.org/r/364672

gerritbot added a comment.Jul 12 2017, 11:49 AM

Change 364666 merged by jenkins-bot:
[mediawiki/extensions/FileAnnotations@master] Replace TextInputWidget (multiline) with MultilineTextInputWidget

https://gerrit.wikimedia.org/r/364666

gerritbot added a comment.Jul 12 2017, 11:49 AM

Change 364672 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] Replace TextInputWidget (multiline) with MultilineTextInputWidget

https://gerrit.wikimedia.org/r/364672

gerritbot added a comment.Jul 12 2017, 11:59 AM

Change 364670 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Replace TextInputWidget (multiline) with MultilineTextInputWidget

https://gerrit.wikimedia.org/r/364670

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)); removed MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)).Jul 12 2017, 12:00 PM
gerritbot added a comment.Jul 12 2017, 12:22 PM

Change 364703 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Use OO.ui.MultilineTextInputWidget

https://gerrit.wikimedia.org/r/364703

gerritbot added a comment.Jul 12 2017, 12:38 PM

Change 364710 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Use OO.ui.MultilineTextInputWidget

https://gerrit.wikimedia.org/r/364710

gerritbot added a comment.Jul 12 2017, 12:41 PM

Change 364710 abandoned by VolkerE:
Use OO.ui.MultilineTextInputWidget

Reason:
Better in one commit: Iad7c5bb32d7fb9c38b1781cce00eec8f1e99f6f2

https://gerrit.wikimedia.org/r/364710

Ricordisamoa subscribed.Jul 12 2017, 1:10 PM
gerritbot added a comment.Jul 12 2017, 3:19 PM

Change 364703 merged by jenkins-bot:
[mediawiki/core@master] Use OO.ui.MultilineTextInputWidget

https://gerrit.wikimedia.org/r/364703

gerritbot added a comment.Jul 12 2017, 3:27 PM

Change 364755 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Math@master] Remove redundant multiline option

https://gerrit.wikimedia.org/r/364755

gerritbot added a comment.Jul 12 2017, 3:28 PM

Change 364756 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Kartographer@master] Remove redundant multiline option

https://gerrit.wikimedia.org/r/364756

gerritbot added a comment.Jul 12 2017, 3:28 PM

Change 364757 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Remove redundant multiline option

https://gerrit.wikimedia.org/r/364757

gerritbot added a comment.Jul 12 2017, 3:31 PM

Change 364759 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Graph@master] Remove redundant multiline option

https://gerrit.wikimedia.org/r/364759

gerritbot added a comment.Jul 12 2017, 3:38 PM

Change 364757 merged by jenkins-bot:
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Remove redundant multiline option

https://gerrit.wikimedia.org/r/364757

gerritbot added a comment.Jul 12 2017, 3:38 PM

Change 364756 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Remove redundant multiline option

https://gerrit.wikimedia.org/r/364756

gerritbot added a comment.Jul 12 2017, 3:47 PM

Change 364759 merged by jenkins-bot:
[mediawiki/extensions/Graph@master] Remove redundant multiline option

https://gerrit.wikimedia.org/r/364759

ReleaseTaggerBot edited projects, added MW-1.30-release-notes; removed MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)).Jul 12 2017, 4:00 PM
• Prtksxna updated the task description. (Show Details)Jul 17 2017, 4:40 AM
gerritbot added a comment.Jul 17 2017, 4:45 AM

Change 365545 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/Teahouse@master] Replace TextInputWidget (multiline) with MultilineTextInputWidget

https://gerrit.wikimedia.org/r/365545

gerritbot added a comment.Jul 17 2017, 4:49 AM

Change 365546 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/CollaborationKit@master] Replace TextInputWidget (multiline) with MultilineTextInputWidget

https://gerrit.wikimedia.org/r/365546

• Prtksxna mentioned this in rECKT0bb6a03da7f8: Replace TextInputWidget (multiline) with MultilineTextInputWidget.Jul 17 2017, 4:49 AM
gerritbot added a comment.Jul 17 2017, 5:00 AM

Change 365546 merged by jenkins-bot:
[mediawiki/extensions/CollaborationKit@master] Replace TextInputWidget (multiline) with MultilineTextInputWidget

https://gerrit.wikimedia.org/r/365546

• Prtksxna updated the task description. (Show Details)Jul 17 2017, 5:13 AM
gerritbot added a comment.Jul 17 2017, 5:54 AM

Change 365550 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/TemplateData@master] Replace TextInputWidget (multiline) with MultilineTextInputWidget

https://gerrit.wikimedia.org/r/365550

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)); removed MW-1.30-release-notes.Jul 17 2017, 6:00 AM
gerritbot added a comment.Jul 17 2017, 9:39 AM

Change 365545 merged by jenkins-bot:
[mediawiki/extensions/Teahouse@master] Replace TextInputWidget (multiline) with MultilineTextInputWidget

https://gerrit.wikimedia.org/r/365545

Jdforrester-WMF assigned this task to • Prtksxna.Jul 17 2017, 3:35 PM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF edited projects, added Contributors-Team; removed Patch-For-Review.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF set the point value for this task to 8.

Looks like we've done all of them? Mark as Resolved?

gerritbot added a comment.Jul 17 2017, 3:36 PM

Change 365550 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] Replace TextInputWidget (multiline) with MultilineTextInputWidget

https://gerrit.wikimedia.org/r/365550

• Prtksxna added a comment.Jul 17 2017, 4:38 PM
In T170275#3444097, @Jdforrester-WMF wrote:

Looks like we've done all of them? Mark as Resolved?

I can't find any other

Volker_E closed this task as Resolved.Jul 17 2017, 5:40 PM
Volker_E moved this task from Doing to Waiting for breaking release on the OOUI board.
gerritbot added a comment.Jul 18 2017, 7:23 PM

Change 364755 merged by jenkins-bot:
[mediawiki/extensions/Math@master] Remove redundant multiline option

https://gerrit.wikimedia.org/r/364755

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)); removed MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)).Jul 18 2017, 8:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits