In the most recent version of T154954, we only purge banner loader URLs for the user's language, since purging for all languages every time a banner is saved would be too harsh on our infrastructure.

For cases where a user wishes to preview a banner (in a not-logged-in context) in a language other than the one they use on-wiki, maybe we could add some controls to the banner editor page to purge for a specified language, one at a time?

Also, to prevent this from becoming a DDOS vector, would we need to limit how often this can be done?

Thanks!!

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Controls to purge banner content from front-end cache for a language	mediawiki/extensions/CentralNotice	master	+258 -11

Customize query in gerrit

Related Objects

Mentioned Here: T154954: Purge Varnish cache when a banner is saved

Event Timeline

• AndyRussG created this task.Jun 22 2017, 6:07 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 22 2017, 6:07 PM

• DStrine renamed this task from CentralNotice: Add controls to purge banner content in Varnish for a specific lanaguage to CentralNotice: Add controls to purge banner content in Varnish for a specific language.Jun 22 2017, 8:13 PM

Thanks @AndyRussG. Yes, being able to purge a specific language other than my own would be an important use case.

Nemo_bis subscribed.Jun 23 2017, 1:10 PM

• DStrine set the point value for this task to 2.Jun 26 2017, 4:27 PM

• DStrine added a project: Fundraising Sprint Loose Lego Carpeting.Jun 26 2017, 7:55 PM

• DStrine moved this task from Triage to Completed in Q4 2016-17 on the Fundraising-Backlog board.

• AndyRussG moved this task from Backlog to Doing on the Fundraising Sprint Loose Lego Carpeting board.Jun 28 2017, 10:55 PM

Hi @ema, @BBlack! :)

Just pinging to see if you have a comment on this aspect of this task:

Also, to prevent this from becoming a DDOS vector, would we need to limit how often this can be done?

Working now on coding up this feature... I think we might do a background call to Special:CentralNoticeBanners with special params to trigger the purge. It would only be available to users with CentralNotice administration rights on Meta. (There are about 60, I think? @Jseddon, is that correct?) Each click on the UI would cause a purge of 6 URLs from Varnish. Do you think we can just suggest people not click gratuitously, or is it necessary to enforce a limit somehow? Thanks!!!! ;)

• DStrine added a project: Fundraising Sprint Murphy's Lawyer.Jul 5 2017, 8:23 PM

• AndyRussG moved this task from Backlog to Doing on the Fundraising Sprint Murphy's Lawyer board.Jul 5 2017, 11:49 PM

• DStrine moved this task from Completed in Q4 2016-17 to Current Sprint and Completed in Q1 2017-18 on the Fundraising-Backlog board.Jul 6 2017, 4:43 PM

Change 364910 had a related patch set uploaded (by AndyRussG; owner: AndyRussG):
[mediawiki/extensions/CentralNotice@master] Controls to purge banner content from front-end cache for a language

https://gerrit.wikimedia.org/r/364910

gerritbot added a project: Patch-For-Review.Jul 12 2017, 10:19 PM

• AndyRussG moved this task from Doing to Review on the Fundraising Sprint Murphy's Lawyer board.Jul 13 2017, 3:11 PM

• DStrine added a project: Fundraising Sprint Navel Warfare.Jul 19 2017, 8:25 PM

Ejegg moved this task from Backlog to Review on the Fundraising Sprint Navel Warfare board.Jul 21 2017, 4:26 PM

Change 364910 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Controls to purge banner content from front-end cache for a language

https://gerrit.wikimedia.org/r/364910

• AndyRussG moved this task from Review to Pending Deployment on the Fundraising Sprint Navel Warfare board.Jul 28 2017, 4:18 PM

• AndyRussG moved this task from Pending Deployment to Done on the Fundraising Sprint Navel Warfare board.Aug 2 2017, 7:36 PM

• DStrine added a project: Fundraising Sprint Outie Inverter.Aug 2 2017, 8:20 PM

• AndyRussG moved this task from Backlog to Done on the Fundraising Sprint Outie Inverter board.Aug 3 2017, 2:40 PM

• DStrine added a project: Fundraising Sprint Prank Seatbelt.Aug 16 2017, 8:30 PM