Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the PredefinedMethodsHelper and related parser components to enhance the handling of predefined method calls and improve test coverage. Key changes include:
- A new instance-based implementation for PredefinedMethodsHelper with a configurable dictionary of supported methods.
- Updated test cases in PredefinedMethodsHelperTests and MethodFinderTest, including renaming test methods for clarity.
- A refactoring in MethodFinder and ExpressionParser to accommodate the new method helper structure.
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/System.Linq.Dynamic.Core.Tests/Parser/PredefinedMethodsHelperTests.cs | Added tests for various supported and unsupported method scenarios. |
| test/System.Linq.Dynamic.Core.Tests/Parser/MethodFinderTest.cs | Modified test cases with updated parameter types and method names. |
| src/System.Linq.Dynamic.Core/Parser/SupportedMethods/MethodFinder.cs | Renamed output parameter to "methodOrConstructor" for clarity. |
| src/System.Linq.Dynamic.Core/Parser/PredefinedMethodsHelper.cs | Transitioned from a static helper to an instance helper with a configurable supported methods dictionary. |
| src/System.Linq.Dynamic.Core/Parser/ExpressionParser.cs | Integrated the instance PredefinedMethodsHelper and updated method accessibility checks. |
| src/System.Linq.Dynamic.Core/DynamicClassFactory.cs | Updated the call to use the new ObjectInstanceToString property. |
Files not reviewed (1)
- .vscode/tasks.json: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.