Skip to content

Most newspapers.com variables no longer map #1665

@skylerbunny

Description

@skylerbunny

I suspect the testing done for newspapers.com clippings, if it's running at all, isn't doing an exhaustive check of what it's supposed to be. In any event, it looks like 'what it grabs' is out of date, because the code refers to fields that have changed names or are no longer there, and most fields the code seems to expect it should autofill don't.

If I attempt to clip one of the test cases in the code using the current VisualEditor on Wikipedia, what I get is this in the autofill for citation fields:

URL: https://www.newspapers.com/clip/18535448
Source title: Clipping from The Sunday Leader - Newspapers.com
Name of publication: Newspapers.com
URL Access Date: 2018-05-26
Language: en

Ideally it would be good if it got at least this (never minding the 'You COULD get the proper title and author if it's formatted in the title correctly' thing, because that relies on the person clipping it to know you have to do that):
URL: https://www.newspapers.com/clip/18535448
Source title: Clipping from The Sunday Leader
Name of publication: The Sunday Leader
URL Access Date: 2018-05-26
Source date: 1887-06-17
Language: en
Page/Pages: 5
Via: Newspapers.com
Location of Publication: Wilkes-Barre, Pennsylvania
Edition: Main Edition

If and when this is fixed, if periodic tests run, they probably want to raise flags if one or more fields drop or change.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions