build(cpack/wix): fix protocol handler registration

trollixx · trollixx · commit b9a25f2cbea2 · 2024-07-21T23:37:45.000-04:00
Fixes #923.
diff --git a/pkg/wix/template.xml b/pkg/wix/template.xml
@@ -50,33 +50,35 @@
         <?include "product_fragment.wxi"?>
 
         <!-- Dash protocol handlers. -->
-        <Feature Id="Protocol" Title="Plugin Support" Level="1"
-            Description="Provides dash:// and dash-plugin:// protocol handlers.">
-            <Component Id="ProtocolHandlers" Directory="TARGETDIR">
-                <?foreach UrlScheme in dash;dash-plugin ?>
-                <RegistryKey Root="HKMU" Key="Software\Classes\$(var.UrlScheme)">
-                    <RegistryValue Type="string" Value="URL: Dash Plugin Protocol (Zeal)" />
-                    <RegistryValue Name="URL Protocol" Type="string" Value="" />
-
-                    <RegistryKey Key="DefaultIcon">
-                        <RegistryValue Type="string" Value="&quot;[CM_FP_zeal.exe],1&quot;" />
-                    </RegistryKey>
-
-                    <RegistryKey Key="shell\open\command">
-                        <RegistryValue Type="string" Value="&quot;[CM_FP_zeal.exe]&quot; &quot;%1&quot;" />
-                    </RegistryKey>
+        <Component Id="ProtocolHandlers" Directory="INSTALL_ROOT">
+            <?foreach UrlScheme in dash;dash-plugin ?>
+            <!-- Remove broken HKCU keys. -->
+            <RemoveRegistryKey Action="removeOnInstall" Root="HKCU" Key="Software\Classes\$(var.UrlScheme)" />
+
+            <RegistryKey Root="HKLM" Key="Software\Classes\$(var.UrlScheme)">
+                <RegistryValue Type="string" Value="URL:Dash Plugin Protocol (Zeal)" />
+                <RegistryValue Name="URL Protocol" Type="string" Value="" />
+
+                <RegistryKey Key="DefaultIcon">
+                    <RegistryValue Type="string" Value="&quot;[#CM_FP_zeal.exe],1&quot;" />
+                </RegistryKey>
+
+                <RegistryKey Key="shell\open\command">
+                    <RegistryValue Type="string" Value="&quot;[#CM_FP_zeal.exe]&quot; &quot;%1&quot;" />
                 </RegistryKey>
-                <?endforeach ?>
-            </Component>
-        </Feature>
+            </RegistryKey>
+            <?endforeach ?>
+        </Component>
 
         <!-- Custom properties to control installation options -->
         <Property Id="LAUNCHAPPONEXIT" Value="1" Secure="yes"/>
 
         <!-- Set properties based on existing conditions, prevents changing state on upgrade. -->
         <SetProperty Id="LicenseAccepted" After="AppSearch" Value="1">WIX_UPGRADE_DETECTED</SetProperty>
 
-        <FeatureRef Id="ProductFeature"/>
+        <FeatureRef Id="ProductFeature">
+            <ComponentRef Id="ProtocolHandlers" />
+        </FeatureRef>
 
         <!-- Action to launch application after installer exits. -->
         <Property Id="WixShellExecTarget" Value="[#CM_FP_zeal.exe]"/>
