Skip to content

Commit 860d5d4

Browse files
Expand docstring for hub_url
Co-authored-by: Erik Sundell <erik.i.sundell@gmail.com>
1 parent ab34761 commit 860d5d4

File tree

1 file changed

+18
-11
lines changed

1 file changed

+18
-11
lines changed

jupyterhub_ssh/__init__.py

Lines changed: 18 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -226,20 +226,27 @@ class JupyterHubSSH(Application):
226226
"",
227227
help="""
228228
URL of JupyterHub's proxy to connect to.
229-
230-
`jupyterhub-ssh` needs to be able to connect to both the
231-
JupyterHub API and to the user's server. If running in
232-
the same cluster as the JupyterHub, this should point to
233-
the `proxy-public` service. When running outside the same
234-
cluster, this should be set to the user accessible URL of
235-
the hub.
229+
230+
jupyterhub-ssh needs to be able to connect to both the JupyterHub API
231+
(/hub/api) and to the users' servers (/user/<username>) via HTTP or
232+
HTTPS. This URL doesn't have to be the public URL though as the URL is
233+
only be used by jupyterhub-ssh itself.
236234
237235
*Must* be set.
238-
236+
239237
Examples:
240-
241-
`http://proxy-public` (in same cluster & namespace as jupyterhub)
242-
`https://my-hub-url.com` (when running outside the cluster)
238+
239+
- If jupyterhub-ssh is deployed in the same Kubernetes cluster and
240+
namespace as the official JupyterHub Helm chart, you can use
241+
`http://proxy-public` or `http://proxy-http:8000` depending on
242+
how the JupyterHub Helm chart is configured. Use
243+
`http://proxy-http:8000` if the JupyterHub Helm chart has been
244+
configured with both `proxy.https.enabled=true` and
245+
`proxy.https.type=letsencrypt`, otherwise use `http://proxy-public`.
246+
247+
- If jupyterhub-ssh can't access JupyterHub's proxy via local network or
248+
you don't trust the local network to be secure, use a public URL with
249+
HTTPS such as `https://my-hub-url.com`.
243250
""",
244251
config=True,
245252
)

0 commit comments

Comments
 (0)