Provide build option to disable xr in blink #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces a build argument 'disable_xr' that allows disabling XR modules in Blink, reducing the binary size for lightweight builds. Change-Id: Iab6d36de5fccbe78f8051a2100fe60718be1d537
|
I've merged this in our main repo in |
|
Lets use https://github.com/youtube/cobalt going forward, please make the pull requests against https://github.com/youtube/cobalt/tree/experimental/m138-lightweight branch |
|
QQ - has this CL been landed upstream, in Chromium repo? I would think this might be interesting for other content embedders e.g. Chromecast or Fuchsia. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a build argument 'disable_xr' that allows disabling XR modules in Blink, reducing the binary size for lightweight builds.