cobalt: Only observe WebContents on main app #7857
Conversation
borongc
force-pushed
the
two_web_contents
branch
from
e4b25ba to
afe96e3
Compare
|
/generate-commit-message |
🤖 Gemini Suggested Commit Message |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to optimize resource usage by preventing observers from attaching to the splash screen's WebContents. However, the current implementation has a critical flaw: it checks for the splash screen by inspecting the main frame's name within the OnWebContentsCreated callback, but at this stage of the WebContents lifecycle, the main frame has not yet been created. This means the check will always fail, and the optimization will not be effective. I have provided a critical review comment detailing this issue and suggesting a more robust solution using the WebContentsUserData pattern, which is standard practice in Chromium for such cases. Additionally, I've noted an inconsistency where the logic is unnecessarily restricted to Android, which would prevent the optimization from working on other platforms.
borongc
force-pushed
the
two_web_contents
branch
from
afe96e3 to
ec7eb66
Compare
Issue: 441738743
borongc
force-pushed
the
two_web_contents
branch
from
ec7eb66 to
1b8e873
Compare
2 participants
Prevent CobaltWebContentsObserver and CobaltWebContentsDelegate from
attaching to the splash screen WebContents. The splash screen does not
require the full suite of Cobalt-specific browser event handling or
delegation, ensuring resources are allocated only where necessary.
Issue: 441738743