Add missing dependencies needed for Kimono #7849
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we know why we didn't need these explicit deps in m114? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: 454931711
Under m114, we have a load of jar files under out/$TARGET/lib.java which are missing under m138.
CoAT runs fine, so these are all only needed for Kimono.
As listed in b/454931711 these are missing and are used in our build scripts
lib.java/third_party/android_deps/utils/java.jar
lib.java/third_party/androidx/androidx_appcompat_appcompat_resources_java.jar
lib.java/third_party/androidx/androidx_core_core_java.jar
Using 'androidx_appcompat_appcompat_resources_java.jar' as an example, it seems this is now packaged as an AAR file - an android specific archive format. Gemini tells me we just need to include the missing depencies to our build target.
Using the list of needed/missing java files in b/456268748 , I've now added the target for each of these as a dependency.