Refactor Cobalt GN targets to use private deps, instead of public_deps #7846
Conversation
This change moves :cobalt_shell_switches and :cobalt_shell_lib_deps from public_deps to deps in cobalt_shell_lib. It also moves :cobalt_shell_app_deps to deps in cobalt_shell_app. This required adding explicit dependencies to several targets that were previously relying on transitive public dependencies from cobalt_shell_lib.
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly refactors dependencies in cobalt_shell_lib and cobalt_shell_app by moving them from public_deps to deps. This improves build encapsulation by reducing transitive dependencies. The consequential changes to add explicit dependencies in other targets seem correct. I found one critical issue where an Android-specific dependency is added unconditionally, which will break builds on other platforms. Please see my comment for details.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors dependencies in the GN build files, moving cobalt_shell_switches and cobalt_shell_lib_deps from public_deps to deps in cobalt_shell_lib, and cobalt_shell_app_deps to deps in cobalt_shell_app. This change correctly reflects the direct dependencies of these targets and ensures that other targets explicitly declare their dependencies, improving build clarity and preventing unintended transitive dependencies. The changes are well-aligned with good dependency management practices.
kjyoun
changed the title
kjyoun
changed the title
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request is a significant and valuable refactoring of the GN build dependencies. Moving dependencies from public_deps to deps is a great step towards improving build hygiene and reducing transitive dependencies. The changes are extensive and appear to be correctly implemented across all the modified BUILD.gn files. I have one minor suggestion to improve the sorting of a dependency list with a conditional dependency.
1 participant
This PR refactors GN build dependencies. The primary goal is to improve build hygiene and modularity by reducing
transitive dependency "leakage."
The two main categories of changes are:
cobalt_shell_lib,cobalt_shell_app, and various test support libraries.Bug: 457596041