cobalt/test: Create new browser test data target #7845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change reduces the number of files that cobalt browser_tests rely on. Cobalt tests failed recently when trying to use symlinks in tests. On the test devices, this was disallowed because they used FAT file systems, where symlinks are not compatible. Bug: 432313695
…eeded. This will be especially useful after rebases to newer milestones and as content/test/data changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a data target that composes Cobalt browser test's data dependencies. This was instrumented by a script that basically links to all of the resource files underneath
//content/test/data. I manually removed the symlink files. The script and its unittest script were added to the data directory for updating the data directory for each rebase.Cobalt tests failed recently when trying to use symlinks in tests. On the test devices, this was disallowed because they used FAT file systems, where symlinks are not compatible. This will require more granular updates to the test data target, but this should be fine and should be a relatively low-effort extra step.
This also removes a file chooser test, which does not reflect a Cobalt CUJ.
Test:
out/android-x86_devel/bin/run_cobalt_browsertests -v -fNote: The linter forced the spacing change in CobaltActivity.java. It is not relevant to this PR.
Bug: 432313695