Cherry-pick Add PipelineStatusCode DEMUXER_ERROR_PROGRESSIVE_DISABLED #7827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides a more accurate error when the FFmpeg/Progressive Demuxer fails to be created due to a build or runtime configuration. Previously, this scenario would report a less precise catch-all error DEMUXER_ERROR_COULD_NOT_OPEN. Bug: 422452498 Change-Id: I087023045c8a32edb12ebb5d0be44863294aea55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7099119 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Austin Osagie <austinosagie@google.com> Reviewed-by: Caitlin Fischer <caitlinfischer@google.com> Auto-Submit: Austin Osagie <austinosagie@google.com> Cr-Commit-Position: refs/heads/main@{#1538857}
borongc
reviewed
Nov 1, 2025
| <enum name="PipelineStatus"> | ||
| <int value="0" label="PIPELINE_OK"/> | ||
| <int value="1" label="PIPELINE_ERROR_URL_NOT_FOUND"/> | ||
| <int value="1" label="(Deprecated) PIPELINE_ERROR_URL_NOT_FOUND"/> |
There was a problem hiding this comment.
Looks like not from this cherry pick PR?
borongc
reviewed
Nov 1, 2025
| <int value="8" label="PIPELINE_ERROR_COULD_NOT_RENDER"/> | ||
| <int value="9" label="PIPELINE_ERROR_READ"/> | ||
| <int value="10" label="PIPELINE_ERROR_OPERATION_PENDING"/> | ||
| <int value="10" label="(Deprecated) PIPELINE_ERROR_OPERATION_PENDING"/> |
borongc
reviewed
Nov 1, 2025
| <int value="18" label="CHUNK_DEMUXER_ERROR_EOS_STATUS_NETWORK_ERROR"/> | ||
| <int value="19" label="AUDIO_RENDERER_ERROR"/> | ||
| <int value="20" label="AUDIO_RENDERER_ERROR_SPLICE_FAILED"/> | ||
| <int value="20" label="(Deprecated) AUDIO_RENDERER_ERROR_SPLICE_FAILED"/> |
|
We should consider to put this to 26.android branch as well (possible 26.eap). |
borongc
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks crrev.com/c/7099119 to add a new PipelineStatusCode
DEMUXER_ERROR_PROGRESSIVE_DISABLED. Additionally, this error code was added to pipeline_status.ccPipelineStatusToString, and added in the Cobalt-specific progressive demuxer section in theDemuxerManager.The original commit message follows.
This provides a more accurate error when the FFmpeg/Progressive Demuxer fails to be created due to a build or runtime configuration. Previously, this scenario would report a less precise catch-all error DEMUXER_ERROR_COULD_NOT_OPEN.
Bug: 422452498
Change-Id: I087023045c8a32edb12ebb5d0be44863294aea55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7099119
Reviewed-by: Dale Curtis dalecurtis@chromium.org
Commit-Queue: Austin Osagie austinosagie@google.com
Reviewed-by: Caitlin Fischer caitlinfischer@google.com
Auto-Submit: Austin Osagie austinosagie@google.com
Cr-Commit-Position: refs/heads/main@{#1538857}