android: Add unit tests for CobaltService #7824
Open
+169
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/generate-commit-message |
🤖 Gemini Suggested Commit Message |
zhongqiliang
force-pushed
the
locale_unit_test
branch
from
c343015 to
7ea4a3e
Compare
|
Remove Locale.US in CobaltService.java, the test will fail. |
yell0wd0g
reviewed
Nov 4, 2025
Comment on lines
+92
to
+100
| String jsCodeTemplate = | ||
| "((w) => {\n" | ||
| + " let targetWindow = w;\n" | ||
| + " const appIframe = document.getElementById('anchor');\n" | ||
| + " if (appIframe?.contentWindow) {\n" | ||
| + " targetWindow = appIframe.contentWindow;\n" | ||
| + " }\n" | ||
| + " targetWindow.H5vccPlatformService.callbackFromAndroid(%d, '%s');\n" | ||
| + "})(window)"; |
There was a problem hiding this comment.
Actually one question - does it matter this content, as long as it's
valid JS?
There was a problem hiding this comment.
It's a good point. This block has to exactly match the Java Bridge script. Any changes to the original script would result in this test failing.
johnxwork
approved these changes
Nov 4, 2025
|
|
||
| } finally { | ||
| // Restore the original default locale to avoid affecting other tests. | ||
| Locale.setDefault(originalLocale); |
There was a problem hiding this comment.
you would want to fail the test if any exception is thrown and the assertEquals doesn't get executed, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces unit tests for the CobaltService.sendToClient method
on Android. The tests verify that JavaScript code is consistently formatted
using Locale.US, preventing issues with locale-dependent number formatting.
Additionally, it ensures that the method handles a null CobaltActivity
gracefully without causing crashes.
Test log: https://paste.googleplex.com/6270902119563264
Bug: 455895170
Change-Id: I8811cad1da6d8d9016b3bf70e3ab09a7bd7a9899