Skip to content

evergreen: Prep the updater for Cobalt #7811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2025
Merged

evergreen: Prep the updater for Cobalt #7811

merged 1 commit into from
Nov 4, 2025

Conversation

@yuying-y
Copy link
Contributor

@yuying-y yuying-y commented Oct 31, 2025 •
edited
Loading

This change resolve remaining issues of the updater module to prepare it for integrating with the cobalt shell.

Key changes:

  • Resolved a circular dependency between cobalt/updater and cobalt/shell by moving updater-related switches to cobalt/updater/configurator.cc.
  • Remove circular dependency between //cobalt/updater and //components/update_client by moving relevant constants and functions to components/update_client/utils.*
  • Improved the destruction sequence of the UpdaterModule to prevent crashes on exit.
  • The hash verification functions in components/update_client/utils.cc are ported from 25.lts.1+.

Issues: 431862767, 213388707

@yuying-y yuying-y requested review from a team as code owners October 31, 2025 05:36
@yuying-y yuying-y requested review from y4vor and removed request for a team October 31, 2025 05:36
@yuying-y yuying-y force-pushed the enable_updater branch 2 times, most recently from 5ff75d7 to 38998f2 Compare October 31, 2025 06:10
andrewsavage1
andrewsavage1 reviewed Oct 31, 2025
View reviewed changes
@yuying-y yuying-y changed the title evergreen: Enable the updater for Cobalt evergreen: Prep the updater for Cobalt Nov 4, 2025
yuying-y referenced this pull request Nov 4, 2025
@yuying-y
evergreen: enable the updater for Cobalt
255bb46 
This change enables the updater by integrating it with the Cobalt shell.

Issues: 431862767, 213388707
@yuying-y yuying-y mentioned this pull request Nov 4, 2025
Open
andrewsavage1
andrewsavage1 approved these changes Nov 4, 2025
View reviewed changes
@yuying-y
evergreen: prep the updater for Cobalt
7ec4c94 
This change resolve remaining issues of the updater module to
prepare it for integrating with the cobalt shell.

Issues: 431862767, 213388707
@yuying-y yuying-y merged commit 19791ff into youtube:26.eap Nov 4, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewsavage1 andrewsavage1 andrewsavage1 approved these changes

@y4vor y4vor Awaiting requested review from y4vor y4vor is a code owner automatically assigned from youtube/cobalt-3p-repository-owners

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yuying-y @andrewsavage1