android: Capture top 4 Java stack frames on exception #7191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongqiliang
changed the title
johnxwork
reviewed
Sep 16, 2025
johnxwork
approved these changes
Sep 16, 2025
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Sep 16, 2025
The previous FindFirstJavaFileAndLine only extracted the first file and line number from a Java exception, which is often insufficient for debugging. This updates the regex to also capture the method name and iterates to find the top 4 frames of the stack trace. The resulting string (e.g., method1@file1:10&method2@file2:20) will provide much richer context for crash analysis. Bug: 430385989 Change-Id: Ifd005980c49de10e5a257d10e8169026c88449c6 (cherry picked from commit e7c6693)
johnxwork
pushed a commit
that referenced
this pull request
Sep 17, 2025
…eption (#7193) Refer to the original PR: #7191 The previous FindFirstJavaFileAndLine only extracted the first file and line number from a Java exception, which is often insufficient for debugging. This updates the regex to also capture the method name and iterates to find the top 4 frames of the stack trace. The resulting string (e.g., method1@file1:10&method2@file2:20) will provide much richer context for crash analysis. Bug: 430385989 Change-Id: Ifd005980c49de10e5a257d10e8169026c88449c6 Co-authored-by: Colin Liang <colinliang@google.com>
github-actions bot
pushed a commit
that referenced
this pull request
Sep 17, 2025
The previous FindFirstJavaFileAndLine only extracted the first file and line number from a Java exception, which is often insufficient for debugging. This updates the regex to also capture the method name and iterates to find the top 4 frames of the stack trace. The resulting string (e.g., method1@file1:10&method2@file2:20) will provide much richer context for crash analysis. Bug: 430385989 Change-Id: Ifd005980c49de10e5a257d10e8169026c88449c6 original-hexsha: e7c6693
jammel-yeboah
pushed a commit
to jammel-yeboah/cobalt
that referenced
this pull request
Oct 2, 2025
The previous FindFirstJavaFileAndLine only extracted the first file and line number from a Java exception, which is often insufficient for debugging. This updates the regex to also capture the method name and iterates to find the top 4 frames of the stack trace. The resulting string (e.g., method1@file1:10&method2@file2:20) will provide much richer context for crash analysis. Bug: 430385989 Change-Id: Ifd005980c49de10e5a257d10e8169026c88449c6
andrewsavage1
pushed a commit
that referenced
this pull request
Oct 13, 2025
The previous FindFirstJavaFileAndLine only extracted the first file and line number from a Java exception, which is often insufficient for debugging. This updates the regex to also capture the method name and iterates to find the top 4 frames of the stack trace. The resulting string (e.g., method1@file1:10&method2@file2:20) will provide much richer context for crash analysis. Bug: 430385989 Change-Id: Ifd005980c49de10e5a257d10e8169026c88449c6 original-hexsha: e7c6693
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous FindFirstJavaFileAndLine only extracted the first
file and line number from a Java exception, which is often
insufficient for debugging.
This updates the regex to also capture the method name and
iterates to find the top 4 frames of the stack trace.
The resulting string (e.g., method1@file1:10&method2@file2:20)
will provide much richer context for crash analysis.
Bug: 430385989
Change-Id: Ifd005980c49de10e5a257d10e8169026c88449c6