Address comments

kjyoun · kjyoun · commit e20ae6606f50 · 2025-11-03T13:33:43.000-08:00
diff --git a/cobalt/browser/mojom/cobalt_settings.mojom b/cobalt/browser/mojom/cobalt_settings.mojom
@@ -20,9 +20,8 @@ union SettingValue {
 };
 
 interface CobaltSettings {
-  // Synchronous call is used here because this is called during renderer
-  // initialization (RenderThreadStarted) where we need the settings before
-  // proceeding. Though it blocks the render thread, it is acceptable, since it
+  // Synchronous call is used here because this is called before player
+  // creation. Though it blocks the render thread, it is acceptable, since it
   // happens only at the construction stage.
   [Sync]
   GetSetting(string key) => (SettingValue? value);
diff --git a/cobalt/renderer/cobalt_content_renderer_client.cc b/cobalt/renderer/cobalt_content_renderer_client.cc
@@ -96,19 +96,6 @@ CobaltContentRendererClient::CobaltContentRendererClient() {
 
 CobaltContentRendererClient::~CobaltContentRendererClient() = default;
 
-void CobaltContentRendererClient::RenderThreadStarted() {
-  DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
-  mojo::Remote<cobalt::mojom::CobaltSettings> cobalt_settings;
-  content::RenderThread::Get()->BindHostReceiver(
-      cobalt_settings.BindNewPipeAndPassReceiver());
-
-  cobalt::mojom::SettingValuePtr value;
-  if (cobalt_settings->GetSetting("Media.DisableExternalAllocator", &value) &&
-      value && value->is_int_value()) {
-    use_external_allocator_ = value->get_int_value() != 1;
-  }
-}
-
 void CobaltContentRendererClient::RenderFrameCreated(
     content::RenderFrame* render_frame) {
   DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
@@ -203,7 +190,17 @@ void CobaltContentRendererClient::GetStarboardRendererFactoryTraits(
   renderer_factory_traits->audio_write_duration_remote =
       base::Microseconds(kSbPlayerWriteDurationRemote);
 
-  renderer_factory_traits->use_external_allocator = use_external_allocator_;
+  mojo::Remote<cobalt::mojom::CobaltSettings> cobalt_settings;
+  content::RenderThread::Get()->BindHostReceiver(
+      cobalt_settings.BindNewPipeAndPassReceiver());
+
+  bool use_external_allocator = true;
+  cobalt::mojom::SettingValuePtr value;
+  if (cobalt_settings->GetSetting("Media.DisableExternalAllocator", &value) &&
+      value && value->is_int_value()) {
+    use_external_allocator = value->get_int_value() != 1;
+  }
+  renderer_factory_traits->use_external_allocator = use_external_allocator;
 
   // TODO(b/405424096) - Cobalt: Move VideoGeometrySetterService to Gpu thread.
   renderer_factory_traits->bind_host_receiver_callback =
diff --git a/cobalt/renderer/cobalt_content_renderer_client.h b/cobalt/renderer/cobalt_content_renderer_client.h
@@ -41,7 +41,6 @@ class CobaltContentRendererClient : public content::ContentRendererClient {
   ~CobaltContentRendererClient() override;
 
   // ContentRendererClient implementation.
-  void RenderThreadStarted() override;
   void RenderFrameCreated(content::RenderFrame* render_frame) override;
   void GetSupportedKeySystems(::media::GetSupportedKeySystemsCB cb) override;
   bool IsSupportedAudioType(const ::media::AudioType& type) override;
@@ -65,8 +64,6 @@ class CobaltContentRendererClient : public content::ContentRendererClient {
 
   base::ScopedClosureRunner unregister_thread_closure;
 
-  bool use_external_allocator_ = true;
-
   THREAD_CHECKER(thread_checker_);
 };
 
diff --git a/media/mojo/services/gpu_mojo_media_client.h b/media/mojo/services/gpu_mojo_media_client.h
@@ -170,8 +170,6 @@ struct StarboardRendererTraits {
   ~StarboardRendererTraits();
 };
 
-
-
 // Creates a platform-specific media::StarboardRenderer.
 // This is used on Cobalt (android/linux).
 std::unique_ptr<Renderer> CreatePlatformStarboardRenderer(
diff --git a/media/starboard/sbplayer_bridge.cc b/media/starboard/sbplayer_bridge.cc
@@ -758,8 +758,6 @@ void SbPlayerBridge::CreatePlayer() {
 
   player_creation_time_ = Time::Now();
 
-  // TODO(kjyoun): Connect use_external_allocator_ to player.
-
   SbPlayerCreationParam creation_param = {};
   creation_param.drm_system = drm_system_;
   creation_param.audio_stream_info = audio_stream_info_;
