Skip to content

Remove duplicated header. #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
carlonluca wants to merge 1 commit into from
Closed

Remove duplicated header. #82

carlonluca wants to merge 1 commit into from

Conversation

@carlonluca
Copy link
Contributor

@carlonluca carlonluca commented Jul 22, 2022

No description provided.

@carlonluca
Copy link
Contributor Author

carlonluca commented Jul 22, 2022

When placing mldonkey behind a reverse proxy it happens that some requests fail because there is a duplicate "Content-Length" header. My knowledge of ocaml is insufficient to state that simply removing it here is sufficient, but it does not seem that symbol is used often.

@ygrek
Copy link
Owner

ygrek commented Aug 17, 2024

to reproduce :

$ curl -v http://127.0.0.1:4080/bw_updown.png
*   Trying 127.0.0.1:4080...
* Connected to 127.0.0.1 (127.0.0.1) port 4080 (#0)
> GET /bw_updown.png HTTP/1.1
> Host: 127.0.0.1:4080
> User-Agent: curl/7.88.1
> Accept: */*
> Accept-Encoding: deflate, gzip, br, zstd
> 
< HTTP/1.1 200 OK
< Server: MLdonkey/3.1.7.git
< Connection: close
< Content-Type: image/png
< Accept-Ranges: bytes
< Content-Length: 1716
< Cache-Control: no-cache
< Pragma: no-cache
< Content-length: 1716

@ygrek
Copy link
Owner

ygrek commented Aug 17, 2024

content-length header is added uniformly in http_server.ml, so this function is indeed not needed

@ygrek ygrek closed this in b80c733 Aug 17, 2024
carlonluca referenced this pull request in carlonluca/mldonkey Aug 20, 2024
@ygrek @carlonluca
fix duplicated Content-Length header
605a846 
close #82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@carlonluca @ygrek