Ensure temporary files are given legal filenames #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The short_file value for some URLs may result in the string "/". For example, this URL: http://te-home.net/?do=hublist&get=hublist.config.bz2 results in: short_file: / full_file: /?do=hublist&get=hublist.config.bz2 this makes it impossible to save the file. With this change, a random file name is chosen.
ygrek
approved these changes
Jan 28, 2025
Comment on lines
441
to
442
| let prng = Random.State.make_self_init () in | ||
| let rnd = (Random.State.bits prng) land 0xFFFFFF in |
Owner
There was a problem hiding this comment.
really strange why it just doesn't call Random.int
or even better - use mkstemps
carlonluca
referenced
this pull request
in carlonluca/mldonkey
Jan 31, 2025
The short_file value for some URLs may result in the string "/". For example, this URL: http://te-home.net/?do=hublist&get=hublist.config.bz2 results in: short_file: / full_file: /?do=hublist&get=hublist.config.bz2 this makes it impossible to save the file. With this change, a random file name is chosen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The short_file value for some URLs may result in the string "/". For example, this URL:
http://te-home.net/?do=hublist&get=hublist.config.bz2
results in:
short_file: /
full_file: /?do=hublist&get=hublist.config.bz2
this makes it impossible to save the file. With this change, a random file name is chosen.