Use YDB Date32 for Trino dates - #262
Merged
Merged
Conversation
KirillKurdyukov
marked this pull request as ready for review
September 11, 2026 12:55
Collaborator
Author
|
Ready for review, 1/1 among current ready changes. Final scope: JDBC forceSignedDatetimes=true and Date32 for new Trino DATE columns. Exact head c33cd6d; 4 files, +9/-25 = 34 lines. Independent source review and JDK25 compilation passed. Fresh ordinary full CI34818905331 passed: 307 total, 222 passed, 85 skipped, 0 failures/errors. Three original inherited date-test bodies and original DATE mapping cases are restored; temporary diagnostics and special CI modes are removed. Legacy Date range/UPDATE limitations and URL override precedence are documented. This supersedes earlier experimental readiness messages; no automatic merge. |
KirillKurdyukov
marked this pull request as draft
September 11, 2026 13:03
This reverts commit a167d62.
KirillKurdyukov
changed the title
KirillKurdyukov
marked this pull request as ready for review
September 14, 2026 07:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Trino DATE columns use YDB Date32, and connector-created JDBC connections pass forceSignedDatetimes=true. The connector retains the standard Trino date reader/writer and physical column metadata. There is no separate adapter option.
The change restores the three original inherited date tests and the original DATE cases in the data-mapping test by removing earlier overrides. Temporary diagnostic tests, alternate catalogs and CI modes are removed; the workflow matches main.
Exact head:
c33cd6d1ca8da1deb1dcb8b2173a67b46d643ba2. Four files, +9/-25 = 34 changed lines against main119d4bce. Independent exact-commit source review and JDK25 test compilation passed.Fresh full CI passed on merge
874b30e14cf2cdc579f384a1edd5736cccbe7ecf: 307 total, 222 passed, 85 skipped, 0 failures, 0 errors. Smoke: 35 total / 31 passed / 4 skipped. Connector: 272 total / 191 passed / 81 skipped. The ordinary unfiltered suite includes the restored inherited date cases and TopN. Restoring their bodies does not increase the test count. Runtime is verified in CI; local Docker is unavailable.Known limits: this change does not fix the previously observed range-filter and UPDATE problems for legacy Date columns. Do not set forceSignedDatetimes=false in the JDBC URL, whose values override connection properties. Timestamp mappings are unchanged. No new support claim for legacy writes or other temporal types.