fix: prevent 404 on lightbox bound to multi-image field - #485
Merged
Conversation
Multi-image CMS fields resolve to an array, but the lightbox resolver assumed a string and wrapped it in a nested array, which made asset collection throw and 404 the whole page. Reuse parseMultiAssetFieldValue and guard the asset loop against non-string values.
tristan-mouchet
requested review from
liamwalder,
lunenas and
ysamcode
as code owners
August 3, 2026 09:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A dynamic CMS page returned a 404 for the whole page when a Lightbox element with Image Source = CMS Field was bound to a multi-image field. Single-image fields and File Manager worked fine. This fixes the resolution so multi-image fields render correctly.
Changes
parseMultiAssetFieldValuehelper so multi-image field values (arrays) are flattened instead of wrapped in a nested array.startsWith()on raw values, so unexpected shapes can no longer throw and 404 the pageTest plan
curl -ithe item URL returns 200 and the HTML contains a populateddata-lightbox-filesattribute