fix: prevent trigger events from becoming undeletable - #484
Merged
tristan-mouchet merged 1 commit intoAug 3, 2026
Merged
Conversation
Deleting a trigger event with animated properties could silently fail: preview cleanup ran synchronously before the removal, so a GSAP/iframe error aborted the handler before the delete. Wrap cleanup in try/catch in the interaction, tween, and property remove handlers so cosmetic cleanup can never block the actual removal.
tristan-mouchet
requested review from
liamwalder,
lunenas and
ysamcode
as code owners
August 3, 2026 09:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where a trigger event could not be deleted once it had an animated property. Deleting worked fine until a property was added, then the delete did nothing while the rest of the editor stayed responsive.
The event remove handler ran GSAP/iframe preview cleanup synchronously before the actual removal, and that cleanup block only executes when the event has animated properties. If any cleanup call threw in a given environment, the exception aborted the handler before the delete ran, so the event was never removed. This regression was introduced with the background-color animation feature.
Changes
try/catchin the interaction, tween, and property remove handlers so cosmetic cleanup can never block the actual removalTest plan