Add methods to make images using a DynamicGradient#38
Add methods to make images using a DynamicGradient#38gbitaudeau wants to merge 3 commits intoyannickl:masterfrom
Conversation
|
Hi Guillaume, I'm not a big fan of the gradient image API because it introduces inconsistent APIs between DynamicColor is about the color manipulation, not visualisation. Either we create a sub-project with a DynamicGradientView that match the NSGradient However the var isOpaque: Bool {
return colors.reduce(true) { $0.0 && $0.1.isOpaque }
} |
|
Hi Yannick, Tests work on Xcode, it's weird that they fail on travis ... One problem I had on Xcode is that ".png" were compress during compilation, to avoid that I changed their extension using ".ref", but I don't know if it works on travis. I understand your point on APIs inconsistent between At the beginning of my pool request, I have a need: make a color using I will make another request for Thanks for your time. |
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
==========================================
- Coverage 100% 95.17% -4.83%
==========================================
Files 13 14 +1
Lines 390 497 +107
==========================================
+ Hits 390 473 +83
- Misses 0 24 +24
Continue to review full report at Codecov.
|
|
Travis uses Xcode to execute the test suite, so it should work in the same way. I should investigate that when I'll have time. I think I'll create a sub-project with a |
6bf6e34 to
bf0c9e6
Compare
No description provided.