Skip to content

Commit c71f248

Browse files
committed
glance: minor code fixes in ImagesResource
In this patch: * fix indentation for AddMember and RemoveMember * remove unused private Image attributes Signed-off-by: Federico Simoncelli <fsimonce@redhat.com>
1 parent 3e08e60 commit c71f248

File tree

1 file changed

+8
-16
lines changed

1 file changed

+8
-16
lines changed

glance-client/src/main/java/com/woorea/openstack/glance/ImagesResource.java

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -80,22 +80,16 @@ public List(boolean detail) {
8080

8181
public class Create extends OpenStackRequest<Image> {
8282

83-
private Image image;
84-
8583
public Create(Image image) {
8684
super(CLIENT, HttpMethod.POST, "/images", Entity.json(image), Image.class);
87-
this.image = image;
8885
}
8986

9087
}
9188

9289
public class Update extends OpenStackRequest<Image> {
9390

94-
private Image image;
95-
9691
public Update(String id, Image image) {
9792
super(CLIENT, HttpMethod.PUT, new StringBuilder("/images/").append(id).toString(), Entity.json(image), Image.class);
98-
this.image = image;
9993
}
10094

10195
}
@@ -124,8 +118,6 @@ public Image execute() {
124118

125119
public class Upload extends OpenStackRequest<Image> {
126120

127-
private ImageForUpload imageForUpload;
128-
129121
public Upload(ImageForUpload imageForUpload) {
130122
super(CLIENT, HttpMethod.POST, "/images", Entity.stream(imageForUpload.getInputStream()), Image.class);
131123
header("x-image-meta-name", imageForUpload.getName());
@@ -182,20 +174,20 @@ public ReplaceMembers(String id, Collection<ImageMember> members) {
182174

183175
public class AddMember extends OpenStackRequest<ImageMember> {
184176

185-
public AddMember(String id, String tenantId) {
186-
super(CLIENT, HttpMethod.PUT, new StringBuilder("/images/").append(id).append("/members").append(tenantId).toString(), null, ImageMember.class);
177+
public AddMember(String id, String tenantId) {
178+
super(CLIENT, HttpMethod.PUT, new StringBuilder("/images/").append(id).append("/members").append(tenantId).toString(), null, ImageMember.class);
179+
}
180+
187181
}
188-
189-
}
190182

191183
public class RemoveMember extends OpenStackRequest<Void> {
192184

193-
public RemoveMember(String id, String tenantId) {
194-
super(CLIENT, HttpMethod.DELETE, new StringBuilder("/images/").append(id).append("/members/").append(tenantId).toString(), null, Void.class);
185+
public RemoveMember(String id, String tenantId) {
186+
super(CLIENT, HttpMethod.DELETE, new StringBuilder("/images/").append(id).append("/members/").append(tenantId).toString(), null, Void.class);
187+
}
188+
195189
}
196190

197-
}
198-
199191
public static Image parse(Map<String, String> headers) {
200192
Image image = new Image();
201193
image.setId(headers.get("X-Image-Meta-Id"));

0 commit comments

Comments
 (0)