This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Fix selecting input for newly-inserted post's first control#206
Merged
westonruter merged 6 commits intodevelopfrom Aug 2, 2016
Merged
Fix selecting input for newly-inserted post's first control#206westonruter merged 6 commits intodevelopfrom
westonruter merged 6 commits intodevelopfrom
Conversation
js/customize-post-section.js
Outdated
|
|
||
| // Select the input's contents when the value is a placeholder. | ||
| control.deferred.embedded.done( function() { | ||
| control.container.find( ':input' ).on( 'focus', function() { |
Contributor
There was a problem hiding this comment.
@westonruter What is the use of selecting all input/textarea/select/button ( :input ) when post title field will only be input? I mean why not just use input ?
Contributor
Author
There was a problem hiding this comment.
True. It could just be input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This probably failed with the switch to embedding controls upon expanding a post section.
Fixes #209.