Remove IDisposable implementation

xtqqczze · xtqqczze · commit de99b24319a7 · 2021-07-28T17:20:17.000+01:00
diff --git a/src/System.Management.Automation/engine/hostifaces/PowerShell.cs b/src/System.Management.Automation/engine/hostifaces/PowerShell.cs
@@ -1862,7 +1862,6 @@ private void SetRunspace(Runspace runspace, bool owner)
                 if (RemotePowerShell != null)
                 {
                     RemotePowerShell.Clear();
-                    RemotePowerShell.Dispose();
                 }
 
                 RemotePowerShell = new ClientRemotePowerShell(this, remoteRunspace.RunspacePool.RemoteRunspacePoolInternal);
@@ -1924,7 +1923,6 @@ public RunspacePool RunspacePool
                             if (RemotePowerShell != null)
                             {
                                 RemotePowerShell.Clear();
-                                RemotePowerShell.Dispose();
                             }
 
                             RemotePowerShell = new
@@ -4173,11 +4171,6 @@ private void Dispose(bool disposing)
                     _runspace.Dispose();
                 }
 
-                if (RemotePowerShell != null)
-                {
-                    RemotePowerShell.Dispose();
-                }
-
                 _invokeAsyncResult = null;
                 _stopAsyncResult = null;
             }
diff --git a/src/System.Management.Automation/engine/remoting/client/ClientRemotePowerShell.cs b/src/System.Management.Automation/engine/remoting/client/ClientRemotePowerShell.cs
@@ -15,7 +15,7 @@ namespace System.Management.Automation.Runspaces.Internal
     /// PowerShell client side proxy base which handles invocation
     /// of powershell on a remote machine.
     /// </summary>
-    internal sealed class ClientRemotePowerShell : IDisposable
+    internal sealed class ClientRemotePowerShell
     {
         #region Tracer
 
@@ -934,20 +934,6 @@ private void HandleRobustConnectionNotification(
         private PSConnectionRetryStatus _connectionRetryStatus = PSConnectionRetryStatus.None;
 
         #endregion Private Fields
-
-        #region IDisposable
-
-        /// <summary>
-        /// Release all resources.
-        /// </summary>
-        public void Dispose()
-        {
-            // inputstream.Dispose();
-            // outputstream.Dispose();
-            // errorstream.Dispose();
-        }
-
-        #endregion IDisposable
     }
 
     #region PSConnectionRetryStatusEventArgs

Original file line number	Diff line number	Diff line change
`@@ -1862,7 +1862,6 @@ private void SetRunspace(Runspace runspace, bool owner)`
`1862`	`1862`	`if (RemotePowerShell != null)`
`1863`	`1863`	`{`
`1864`	`1864`	`RemotePowerShell.Clear();`
`1865`		`- RemotePowerShell.Dispose();`
`1866`	`1865`	`}`
`1867`	`1866`
`1868`	`1867`	`RemotePowerShell = new ClientRemotePowerShell(this, remoteRunspace.RunspacePool.RemoteRunspacePoolInternal);`
`@@ -1924,7 +1923,6 @@ public RunspacePool RunspacePool`
`1924`	`1923`	`if (RemotePowerShell != null)`
`1925`	`1924`	`{`
`1926`	`1925`	`RemotePowerShell.Clear();`
`1927`		`- RemotePowerShell.Dispose();`
`1928`	`1926`	`}`
`1929`	`1927`
`1930`	`1928`	`RemotePowerShell = new`
`@@ -4173,11 +4171,6 @@ private void Dispose(bool disposing)`
`4173`	`4171`	`_runspace.Dispose();`
`4174`	`4172`	`}`
`4175`	`4173`
`4176`		`- if (RemotePowerShell != null)`
`4177`		`- {`
`4178`		`- RemotePowerShell.Dispose();`
`4179`		`- }`
`4180`		`-`
`4181`	`4174`	`_invokeAsyncResult = null;`
`4182`	`4175`	`_stopAsyncResult = null;`
`4183`	`4176`	`}`