add binding for xtensor_fixed #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Awesome! LGTM |
JohanMabille
requested changes
Mar 4, 2022
Member
JohanMabille
left a comment
JohanMabille
left a comment
There was a problem hiding this comment.
Awesome! With a slight change to simplify the code it will be perfect ;)
| static bool run(const B& buf) | ||
| { | ||
| auto shape = FSH(); | ||
| for (std::size_t i = 0; i < shape.size(); ++i) |
Member
There was a problem hiding this comment.
This could be simplified with std::equal
Member
Author
There was a problem hiding this comment.
I implemented the first version with std::equal. The problem is that buf.shape()is not an iterator.
Member
There was a problem hiding this comment.
Then you can use &(buf.shape(0)) and we should definitely open an issue on the pybind11 repo so that they provide an iterator API for the shape.
JohanMabille
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.