Skip to content

Added missing types in pystrides_adaptor #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohanMabille merged 1 commit into from
Mar 26, 2019
Merged

Added missing types in pystrides_adaptor #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions include/xtensor-python/pyarray.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,11 +256,14 @@ namespace xt
using array_type = A;
using value_type = typename array_type::size_type;
using const_reference = value_type;
using reference = const_reference;
using const_pointer = const value_type*;
using pointer = const_pointer;
using size_type = typename array_type::size_type;
using difference_type = typename array_type::difference_type;

using const_iterator = pybackstrides_iterator<self_type>;
using iterator = const_iterator;

pyarray_backstrides() = default;
pyarray_backstrides(const array_type& a);
Expand Down
4 changes: 4 additions & 0 deletions include/xtensor-python/pystrides_adaptor.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,16 @@ namespace xt

using value_type = std::ptrdiff_t;
using const_reference = value_type;
using reference = const_reference;
using const_pointer = const value_type*;
using pointer = const_pointer;
using size_type = std::size_t;
using difference_type = std::ptrdiff_t;

using const_iterator = pystrides_iterator<N>;
using iterator = const_iterator;
using const_reverse_iterator = std::reverse_iterator<const_iterator>;
using reverse_iterator = const_reverse_iterator;

pystrides_adaptor() = default;
pystrides_adaptor(const_pointer data, size_type size);
Expand Down