Repository navigation
Adding "digitize", "searchsorted", and "bin_items" - #2037
Merged
Merged
Conversation
tdegeus
changed the title
tdegeus
marked this pull request as ready for review
May 3, 2020 12:22
JohanMabille
requested changes
May 4, 2020
Member
Author
|
Thanks @JohanMabille ! |
Member
Author
|
I wanted to restart the Azure pipelines for all platforms (because it only shows OSX here), but not sure if it worked. Anyway, normally things should be good-to-go. |
Member
|
Looks like Azure didn't report everything to Github. However, everything run fine. |
JohanMabille
approved these changes
May 5, 2020
doronbehar
reviewed
Oct 26, 2026
Comment on lines
+177
to
+190
| if (right) | ||
| { | ||
| for (size_t i = 0; i < v.size(); ++i) | ||
| { | ||
| out(i) = std::lower_bound(a.cbegin(), a.cend(), v(i)) - a.cbegin(); | ||
| } | ||
| } | ||
| else | ||
| { | ||
| for (size_t i = 0; i < v.size(); ++i) | ||
| { | ||
| out(i) = std::upper_bound(a.cbegin(), a.cend(), v(i)) - a.cbegin(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Hey, this seems backwards to me. Is np.searchsorted(a, v, side="right") supposed to be identical to xt::searchsorted(a, v, true)? Because it doesn't... Considering the docstring of course... Maybe the docstring should be updated (to not break people's existing usages of this function).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description