feat(model): complete Qwen3.8 support - #5339
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for the qwen3.8-max model, updates automatic download hub detection to avoid routing large downloads through environment-configured proxies, and adds top_k sampling support to the MLX engine. It also implements streaming tool-call parsing for MLX and adds comprehensive tests. The reviewer feedback suggests filtering out None values when updating the model generation configuration in MLX to prevent downstream type errors, and casting top_k to an integer to avoid cache key mismatches or type errors in the sampler.
OliverBryant
left a comment
There was a problem hiding this comment.
Found one streaming correctness issue.
OliverBryant
left a comment
There was a problem hiding this comment.
Found one ordering issue in the follow-up fix.
OliverBryant
left a comment
There was a problem hiding this comment.
Found one remaining multi-call ordering issue.
OliverBryant
left a comment
There was a problem hiding this comment.
Verified the three streaming-order fixes from the earlier rounds hold, and re-checked the two Gemini findings as genuinely fixed. Three new items below: one real streaming regression, one connectivity regression, one doc/impl mismatch.
|
Re-checked all four fixes in P1 MLX cache aliasing — P2 malformed sibling call — re-ran my original repro against both revisions: Now strictly better than P2 CA bundle — verified the narrowed fix does both things it needs to: P3 docs — scheme-dependent wording is accurate now, and the code comment at All three new regression tests fail on One thing I did not verify: no MLX hardware here, so the prompt-cache path is only checked against upstream mlx-lm's logic and the unit tests, not a live batch run. |
Summary
Tests