core: (Assembly Format) remove return value from parse - #6424
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6424 +/- ##
==========================================
- Coverage 86.95% 86.95% -0.01%
==========================================
Files 439 439
Lines 66019 65964 -55
Branches 7514 7513 -1
==========================================
- Hits 57409 57356 -53
+ Misses 7038 7037 -1
+ Partials 1572 1571 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
superlopuh
approved these changes
Sep 5, 2026
alexarice
force-pushed
the
alexarice/remove-return
branch
from
September 5, 2026 13:34
53c6990 to
62c71c6
Compare
alexarice
added a commit
that referenced
this pull request
Sep 11, 2026
Fixes the `parse` and adds `parse_optional` methods for `KeywordDirective` and `PunctuationDirective`, making these no longer accept the empty string outside of optional groups. This revealed two bugs in `arm_neon` and `tosa`. I've tried to fix both in the a way that seems to make the most sense to me, but it would be good if these could be checked. Stacked on top of #6424
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the now unnecessary return value from
parse. Fairly big diff as this touches all the custom directives.Stacked on #6423