Skip to content

Add hostname option to set the interface to bind to #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
felixfbecker merged 4 commits into from
Mar 6, 2019
Merged

Add hostname option to set the interface to bind to #330

felixfbecker merged 4 commits into from
Mar 6, 2019

Conversation

@martin-schulze-vireso
Copy link
Contributor

@martin-schulze-vireso martin-schulze-vireso commented Jan 29, 2019 •
edited
Loading

This just amends mscharley's PR #289 by he changes that were requested over there.

@martin-schulze-vireso martin-schulze-vireso mentioned this pull request Jan 29, 2019
Closed
@martin-schulze-vireso
Copy link
Contributor Author

martin-schulze-vireso commented Jan 31, 2019

@felixfbecker The travis test seems to fail due to a missing dependency (brew install php@7.0) and not because of the new code.

@codecov
Copy link

codecov bot commented Jan 31, 2019 •
edited by ghost
Loading

Codecov Report

Merging #330 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
+ Coverage   70.05%   70.11%   +0.05%     
==========================================
  Files           5        5              
  Lines        1012     1014       +2     
  Branches      161      161              
==========================================
+ Hits          709      711       +2     
  Misses        303      303
Impacted Files Coverage Δ
src/phpDebug.ts 66.93% <100%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59cd7fb...4a0ba66. Read the comment docs.

@martin-schulze-vireso
Copy link
Contributor Author

martin-schulze-vireso commented Feb 4, 2019

Seeing that you merged in master @felixfbecker, is there anything more I should do?

@felixfbecker
Copy link
Contributor

felixfbecker commented Feb 4, 2019

Well the build is not passing and I'm not sure why

@martin-schulze-vireso
Copy link
Contributor Author

martin-schulze-vireso commented Feb 4, 2019 •
edited
Loading

@felixfbecker as mentioned above, installing php via brew fails (this is a problem of the CI not of the code). I am not well versed with brew so I cannot help much there but it sounds like PHP 7.0 is not available anymore on homebrew, so you probably need to do a php version bump on the recipe.

@martin-schulze-vireso
Copy link
Contributor Author

martin-schulze-vireso commented Mar 4, 2019 •
edited
Loading

@felixfbecker There, I fixed it for you

@martin-schulze-vireso
Copy link
Contributor Author

martin-schulze-vireso commented Mar 6, 2019

@felixfbecker Is there anything more needed?

@felixfbecker felixfbecker merged commit c7280b6 into xdebug:master Mar 6, 2019
@felixfbecker
Copy link
Contributor

felixfbecker commented Mar 6, 2019

🎉 This PR is included in version 1.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

towhidabsar pushed a commit to towhidabsar/vscode-php-debug that referenced this pull request Apr 29, 2019
@martin-schulze-vireso @towhidabsar
feat: add hostname option to set the interface to bind to (xdebug#330)
a15e45d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felixfbecker felixfbecker felixfbecker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@martin-schulze-vireso @felixfbecker @mscharley