Bug fixes #3
Merged
Bug fixes #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert unicode non-breaking spaces to ASCII spaces on handling a previewed or posted message - without this, the parser doesn't recognise smileys correctly. Redirect drag / drop events to the plupload element if it exists - without this, dragging an image to the edit window embeds it as base64 text, crashing the browser.
Owner
|
if you modify smiley.js directly it will overwrite when I upgrade the library. You should download the sources of that component from ckeditor and add the unminified edited version. |
revert ckeditor source - this is the wrong place to fix this
Contributor
Author
|
I've come up with a better solution that avoids changing the ckeditor source. It should also have a better chance of not having to be rewritten with an upgrade to CKEditor5 (if that ever happens). The alternative solution is, when getting the returned data from the editor window, identify smileys without a leading space, and add them where appropriate. |
Owner
|
added to 1.7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert unicode non-breaking spaces to ASCII spaces on handling a previewed or posted message - without this, the parser doesn't recognise smileys correctly. Redirect drag / drop events to the plupload element if it exists - without this, dragging an image to the edit window embeds it as base64 text, crashing the browser.