Skip to content

Conversation

@samwilson
Copy link
Member

This adds the option of showing pages from all namespaces when
viewing top-edits for a user.

Also, the dymanic namespace-selection is given a loading spinner,
and the new-namespace display code accounts for when there isn't
an 'all' option.

Bug: https://phabricator.wikimedia.org/T160721

@codecov-io
Copy link

codecov-io commented Apr 26, 2017

Codecov Report

Merging #23 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   12.24%   12.18%   -0.07%     
==========================================
  Files          19       19              
  Lines        2523     2536      +13     
==========================================
  Hits          309      309              
- Misses       2214     2227      +13
Impacted Files Coverage Δ
src/AppBundle/Controller/TopEditsController.php 18.03% <0%> (-2.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c15721...fd2f824. Read the comment docs.

@samwilson samwilson force-pushed the all-namespaces-T160721 branch from 6997ec0 to 628c077 Compare April 26, 2017 01:32
This adds the option of showing pages from all namespaces when
viewing top-edits for a user.

Also, the dymanic namespace-selection is given a loading spinner,
and the new-namespace display code accounts for when there isn't
an 'all' option.

Bug: https://phabricator.wikimedia.org/T160721
@samwilson samwilson force-pushed the all-namespaces-T160721 branch from 628c077 to fd2f824 Compare April 26, 2017 01:33
Copy link
Member

@Matthewrbowker Matthewrbowker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@samwilson samwilson merged commit 8aef081 into master May 1, 2017
@samwilson samwilson deleted the all-namespaces-T160721 branch May 1, 2017 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants