Skip to content

Commit 7af7866

Browse files
cushonneozwu
authored andcommitted
Add missing "fall through" comments to switches that fall through
The Style Guide requires that within a switch block, each statement group either terminates abruptly (e.g. with a break), or is marked with a comment to indicate that execution may "fall through" to next statement group. This change is being made in preparation for enabling a new compiler error, which will ensure a "fall through" comment is present if and only if the switch falls through. NOTE TO REVIEWERS: Please review carefully to ensure the fall through is deliberate. If it is a bug and there should e.g. be a 'break;' statement, please respond with a suggested edit. More information: https://docs.google.com/a/google.com/document/d/1cz7o7p9ROfXZ0VMtUfFN7Tnw3F61qkFw9bnJ64GDiP8/edit?usp=sharing Tested: TAP --sample for global presubmit queue http://test/OCL:147852686:BASE:147857215:1487376286182:2ba055dd ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=148101033
1 parent 289d90a commit 7af7866

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

google-api-client/src/test/java/com/google/api/client/googleapis/media/MediaHttpUploaderTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -234,6 +234,7 @@ public LowLevelHttpResponse execute() throws IOException {
234234
response.addHeader("Range", "bytes=0-" + contentLength);
235235
return response;
236236
}
237+
break;
237238
default:
238239
break;
239240
}

0 commit comments

Comments
 (0)