Skip to content

Commit 16073ef

Browse files
committed
fix OpenAPI resource generation
Resources must have names in the OpenAPI spec. This change names all request resources "body" in the spec.
1 parent 112ae33 commit 16073ef

5 files changed

Lines changed: 9 additions & 0 deletions

File tree

endpoints-framework/src/main/java/com/google/api/server/spi/swagger/SwaggerGenerator.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -258,6 +258,7 @@ private void writeApiMethod(ApiMethodConfig methodConfig, EndpointMethod endpoin
258258
TypeToken<?> requestType = parameterConfig.getSchemaBaseType();
259259
Schema schema = repo.getOrAdd(requestType, apiConfig);
260260
BodyParameter bodyParameter = new BodyParameter();
261+
bodyParameter.setName("body");
261262
bodyParameter.setSchema(new RefModel(schema.name()));
262263
operation.addParameter(bodyParameter);
263264
break;

endpoints-framework/src/test/resources/com/google/api/server/spi/swagger/foo_endpoint.swagger

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@
109109
"type": "string"
110110
},
111111
{
112+
"name": "body",
112113
"in": "body",
113114
"required": false,
114115
"schema": {
@@ -145,6 +146,7 @@
145146
"type": "string"
146147
},
147148
{
149+
"name": "body",
148150
"in": "body",
149151
"required": false,
150152
"schema": {

endpoints-framework/src/test/resources/com/google/api/server/spi/swagger/foo_endpoint_default_context.swagger

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@
109109
"type": "string"
110110
},
111111
{
112+
"name": "body",
112113
"in": "body",
113114
"required": false,
114115
"schema": {
@@ -145,6 +146,7 @@
145146
"type": "string"
146147
},
147148
{
149+
"name": "body",
148150
"in": "body",
149151
"required": false,
150152
"schema": {

endpoints-framework/src/test/resources/com/google/api/server/spi/swagger/foo_endpoint_internal.swagger

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,7 @@
157157
"type": "string"
158158
},
159159
{
160+
"name": "body",
160161
"in": "body",
161162
"required": false,
162163
"schema": {
@@ -209,6 +210,7 @@
209210
"type": "string"
210211
},
211212
{
213+
"name": "body",
212214
"in": "body",
213215
"required": false,
214216
"schema": {

endpoints-framework/src/test/resources/com/google/api/server/spi/swagger/foo_endpoint_localhost.swagger

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@
109109
"type": "string"
110110
},
111111
{
112+
"name": "body",
112113
"in": "body",
113114
"required": false,
114115
"schema": {
@@ -145,6 +146,7 @@
145146
"type": "string"
146147
},
147148
{
149+
"name": "body",
148150
"in": "body",
149151
"required": false,
150152
"schema": {

0 commit comments

Comments
 (0)