Skip to content

Commit b796abb

Browse files
committed
Test fixes
1 parent 3849a35 commit b796abb

File tree

3 files changed

+14
-14
lines changed

3 files changed

+14
-14
lines changed

kubernetes/src/main/java/io/kubernetes/client/common/PartialObjectMetadataList.java

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,7 @@ public class PartialObjectMetadataList implements KubernetesListObject {
2323
private String apiVersion;
2424
private String kind;
2525
private V1ListMeta metadata;
26-
private List<KubernetesObject> items;
27-
26+
private List<PartialObjectMetadata> items;
2827

2928
public PartialObjectMetadataList apiVersion(String apiVersion) {
3029
this.apiVersion = apiVersion;
@@ -71,13 +70,12 @@ public void setMetadata(V1ListMeta metadata) {
7170
this.metadata = metadata;
7271
}
7372

74-
@SuppressWarnings("unchecked")
75-
public PartialObjectMetadataList items(List<? extends KubernetesObject> items) {
76-
this.items = (List<KubernetesObject>) items;
73+
public PartialObjectMetadataList items(List<PartialObjectMetadata> items) {
74+
this.items = items;
7775
return this;
7876
}
7977

80-
public PartialObjectMetadataList addItemsItem(KubernetesObject item) {
78+
public PartialObjectMetadataList addItemsItem(PartialObjectMetadata item) {
8179
if (items == null) {
8280
items = new ArrayList<>();
8381
}
@@ -87,13 +85,12 @@ public PartialObjectMetadataList addItemsItem(KubernetesObject item) {
8785

8886
@Override
8987
@Nullable
90-
public List<? extends KubernetesObject> getItems() {
88+
public List<PartialObjectMetadata> getItems() {
9189
return items;
9290
}
9391

94-
@SuppressWarnings("unchecked")
95-
public void setItems(List<? extends KubernetesObject> items) {
96-
this.items = (List<KubernetesObject>) items;
92+
public void setItems(List<PartialObjectMetadata> items) {
93+
this.items = items;
9794
}
9895

9996
@Override

util/src/main/java/io/kubernetes/client/util/generic/GenericKubernetesApi.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,10 @@ public class GenericKubernetesApi<
8181
ApiType extends KubernetesObject, ApiListType extends KubernetesListObject> {
8282

8383
private static final String PARTIAL_OBJECT_METADATA_HEADER =
84-
"as=PartialObjectMetadata;g=meta.k8s.io;v=v1,application/json";
84+
"application/json;as=PartialObjectMetadata;g=meta.k8s.io;v=v1,application/json";
85+
8586
private static final String PARTIAL_OBJECT_METADATA_LIST_HEADER =
86-
"as=PartialObjectMetadataList;g=meta.k8s.io;v=v1,application/json";
87+
"application/json;as=PartialObjectMetadataList;g=meta.k8s.io;v=v1,application/json";
8788

8889
// TODO(yue9944882): supports status operations..
8990
// TODO(yue9944882): supports generic sub-resource operations..

util/src/test/java/io/kubernetes/client/util/generic/GenericKubernetesApiTest.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,8 @@ public void listNamespacedJobWithPartialMetadataObjectListHeader() {
133133
assertEquals(jobList, jobListResp.getObject());
134134
assertNull(jobListResp.getStatus());
135135
verify(1, getRequestedFor(urlPathEqualTo("/apis/batch/v1/namespaces/default/jobs"))
136-
.withHeader("Accept", equalTo("as=PartialObjectMetadataList;g=meta.k8s.io;v=v1,application/json")));
136+
.withHeader("Accept",
137+
equalTo("application/json;as=PartialObjectMetadataList;g=meta.k8s.io;v=v1,application/json")));
137138
}
138139

139140
@Test
@@ -154,7 +155,8 @@ public void getNamespacedJobWithPartialMetadataObjectHeader() {
154155
assertEquals(job, jobResp.getObject());
155156
assertNull(jobResp.getStatus());
156157
verify(1, getRequestedFor(urlPathEqualTo("/apis/batch/v1/namespaces/default/jobs/noxu"))
157-
.withHeader("Accept", equalTo("as=PartialObjectMetadata;g=meta.k8s.io;v=v1,application/json")));
158+
.withHeader("Accept",
159+
equalTo("application/json;as=PartialObjectMetadata;g=meta.k8s.io;v=v1,application/json")));
158160
}
159161

160162
@Test

0 commit comments

Comments
 (0)