Use NOWDOC syntax for multi-line expected HTML strings#3
Merged
juanmaguitar merged 1 commit intomainfrom Feb 23, 2026
Merged
Conversation
Switches $expected in test_card_block_renders_with_background_color from a regular single-quoted string to a NOWDOC (<<<'HTML') with an indented closing marker. The result is easier to read and aligns naturally with the surrounding method indentation. Indented closing markers require PHP 7.3+, which is the minimum version for WordPress 7.0. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$expectedintest_card_block_renders_with_background_colorfrom a single-quoted string to NOWDOC syntax (<<<'HTML')Context
Suggested by @jonsurrell in a review of the companion article: multi-line HTML strings are nicer to write with NOWDOC, and it's worth mentioning that indented closing markers are available since PHP 7.3 (minimum PHP version for WordPress 7.0).
Reference: https://php.watch/versions/7.3/relaxed-heredoc-nowdoc
Test plan
npm run test:phppasses with no regressions🤖 Generated with Claude Code