Add CharacterReferenceEquivalenceTest#2
Merged
juanmaguitar merged 2 commits intomainfrom Feb 23, 2026
Merged
Conversation
Demonstrates that assertEqualHTML normalises all representations of an HTML character (literal, named, decimal, padded decimal, hex, padded hex, and named without semicolon) to the same value before comparing, so tests pass regardless of which encoding is used. Includes a skipped assertSame counterpart that shows why the simpler assertion cannot handle this. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CharacterReferenceEquivalenceTestto demonstrate thatassertEqualHTML()normalises all representations of an HTML character before comparing¬), decimal (¬), padded decimal (¬), hex (¬), padded hex (¬), and named without semicolon (¬)assertSamecounterpart showing why the simpler assertion fails for this case, following the pattern established inLazyLoadImagesTestContext
Prompted by a reviewer suggestion on the companion article draft: any given character has 3–4 base representations and theoretically infinite actual representations, making this a strong showcase for
assertEqualHTML()'s normalisation capabilities.Test plan
npm run test:phppasses with the new test includedmarkTestSkipped()fromtest_assertsame_fails_for_character_referencescauses that test to fail as expected🤖 Generated with Claude Code