Skip to content

Fix test broken by assertEqualHTML whitespace change in WP 7.0 (core #64531) #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juanmaguitar merged 1 commit into from
Feb 23, 2026
Merged

Fix test broken by assertEqualHTML whitespace change in WP 7.0 (core #64531) #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .wp-env.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "https://schemas.wp.org/trunk/wp-env.json",
"core": "https://wordpress.org/wordpress-6.9.zip",
"core": "https://wordpress.org/wordpress-7.0-beta1.zip",
"plugins": ["."],
"phpVersion": "8.2",
"env": {
Expand Down
22 changes: 14 additions & 8 deletions tests/RenderCardBlockTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,13 @@ class RenderCardBlockTest extends WP_UnitTestCase {
* Note: assertEqualHTML normalizes class order — so it doesn't matter
* whether add_class() puts "is-style-outlined" before or after
* "wp-block-my-plugin-card".
*
* Whitespace tip: attributes can span multiple lines (they are part of the
* opening tag, not text nodes). But whitespace *between* elements — like a
* newline between `>` and `<p>` — creates a text node that must match the
* actual output. Since the render callback concatenates $content directly
* with no surrounding whitespace, the expected string must do the same:
* `...><p>...</p></div>` with no gaps.
*/
public function test_card_block_renders_with_background_color(): void {
$attributes = array(
Expand All @@ -28,14 +35,13 @@ public function test_card_block_renders_with_background_color(): void {
$output = my_plugin_render_card_block( $attributes, $inner_content );

// Attribute order and class order don't need to match exactly.
$expected = '
<div
class="is-style-outlined my-custom-class wp-block-my-plugin-card"
style="background-color: #f5f5f5;"
>
<p class="wp-block-paragraph">Hello</p>
</div>
';
// Attributes may be on separate lines for readability — that's fine.
// But there must be no whitespace between > and <p>, since the actual
// output has none (whitespace-only text nodes are compared as-is).
$expected = '<div
class="is-style-outlined my-custom-class wp-block-my-plugin-card"
style="background-color: #f5f5f5;"
><p class="wp-block-paragraph">Hello</p></div>';

$this->assertEqualHTML( $expected, $output );
}
Expand Down