Merged
Conversation
1 task
Collaborator
It's probably fine if we don't support multisite, and just add it when we need it. |
kienstra
approved these changes
May 19, 2023
Collaborator
kienstra
left a comment
kienstra
left a comment
There was a problem hiding this comment.
Hi @johnstonphilip,
Thanks a lot for fixing this.
Now, npm run test:phpunit is passing in my local.
| /phpcs.xml | ||
| /.wp-env.json | ||
| /.wp-env.json.bak | ||
| .phpunit.result.cache |
| else | ||
| npx -p @wordpress/env wp-env run phpunit "phpunit -c /var/www/html/wp-content/wpps-scripts/phpunit.xml.dist /var/www/html/wp-content/plugins/$plugindirname" | ||
| fi | ||
| npx -p @wordpress/env wp-env run --env-cwd=\"wp-content/wpps-scripts\" tests-wordpress phpunit -c ./phpunit.xml.dist /var/www/html/wp-content/plugins/$plugindirname |
Collaborator
There was a problem hiding this comment.
Nice simplification, we don't run multisite tests anyway
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the wp-env project (inside Gutenberg repo), the PHPUnit and Composer packages were removed.
This resulted in PHPunit tests failing to run using wpp-scripts with the message:
The 'phpunit' container has been removed. Please use 'wp-env run tests-cli --env-cwd=wp-content/path/to/plugin phpunit' instead.Note:
This PR changes that over. I haven't had a chance to figure out how to get multisite to work yet, so I have removed that for now.
This may require changes to a few things in your tests suite. See companion PR in pattern-manager for more details on changes required there.