ci: update wp-browser, codeception to latest versions #3059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ased on some failures with wp-graphql-testcase (looking into it)
- update test configs to include backupGlobals and backupStaticAttributes (see: lucatume/wp-browser#673)
…Mutation tests to pass
…stead of random image from the web
- update test classes that had missing variable definitions
- turn off path_coverage - reduce use of ternary statements
|
Code Climate has analyzed commit 8b0c049 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This updates wp-browser and codeception to latest versions.
Idea was to support path_coverage (#2329), but upon testing I'm not sure the tradeoff is worth it as tests will take ~100x longer to execute, and in my case I wasn't even able to successfully execute the tests locally.
That said, this gets us up to newer test depdendencies and updates some tests to factor in changes (like asserting when to expect
_doing_it_wrong()to be called)Does this close any currently open issues?
no